Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

71 feature request r based user defined functions #72

Merged
merged 35 commits into from
Nov 5, 2023

Conversation

mattfidler
Copy link
Member

@mattfidler mattfidler commented Oct 28, 2023

@john-harrold as requested.

This calls a R function inside of rxode2; Still needs

  • function query on solve to make sure the functions are still accessible and have the same number of arguments
  • Sane runtime warnings when the function doesn't do the expected thing (return a single value that can be changed to a double without errors)

This is likely quite slow because it travels between R and C quite a bit, though it could be convenient

@mattfidler mattfidler linked an issue Oct 28, 2023 that may be closed by this pull request
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 152 lines in your changes are missing coverage. Please review.

Comparison is base (36dd96c) 50.95% compared to head (587f16d) 50.90%.

❗ Current head 587f16d differs from pull request most recent head be7213c. Consider uploading reports for the commit be7213c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   50.95%   50.90%   -0.06%     
==========================================
  Files          57       59       +2     
  Lines       12123    12408     +285     
==========================================
+ Hits         6177     6316     +139     
- Misses       5946     6092     +146     
Files Coverage Δ
src/codegen.c 70.04% <100.00%> (+0.26%) ⬆️
src/etTran.cpp 72.68% <100.00%> (-0.02%) ⬇️
src/genModelVars.c 100.00% <100.00%> (ø)
src/init.c 67.30% <100.00%> (+0.64%) ⬆️
src/tran.c 87.59% <100.00%> (+0.03%) ⬆️
src/tran.h 98.59% <ø> (ø)
R/tran.R 82.66% <50.00%> (+0.23%) ⬆️
src/parseFuns.h 66.66% <87.09%> (+3.39%) ⬆️
src/udf.cpp 47.50% <47.50%> (ø)
R/rudf.R 37.00% <37.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattfidler mattfidler merged commit 73114bb into main Nov 5, 2023
7 checks passed
@mattfidler mattfidler deleted the 71-feature-request-r-based-user-defined-functions branch November 5, 2023 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: R based User defined functions
1 participant