Fix ICD LIT connected configurations and zap-generate -o path argument
#462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to specification, if ICD LIT is supported, UAT and LITS features must be supported too. If `CHIP_ICD_LIT_SUPPORT` is selected, select CIP and UAT configs instead of implying them. Signed-off-by: Maciej Baczmanski <maciej.baczmanski@nordicsemi.no>
maciejbaczmanski
requested review from
kkasperczyk-no,
ArekBalysNordic and
markaj-nordic
ArekBalysNordic
approved these changes
Jul 15, 2024
maciejbaczmanski
force-pushed
the
matter_fixes
branch
from
ddc27b4
to
c7a6b1b
Compare
Damian-Nordic
approved these changes
Jul 15, 2024
Fix `-o` path argument to be absolute, or relative to current path. Check if `-o` path argument is an existing directory. Signed-off-by: Maciej Baczmanski <maciej.baczmanski@nordicsemi.no>
maciejbaczmanski
force-pushed
the
matter_fixes
branch
from
c7a6b1b
to
7571735
Compare
kkasperczyk-no
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHIP_ICD_LIT_SUPPORT-opath argument to be relative to.zapfile's location instead of Matter library's location.manifest-pr-skip