Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ICD LIT connected configurations and zap-generate -o path argument #462

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Fix ICD LIT connected configurations and zap-generate -o path argument #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ee2f32
[nrf toup][nrfconnect] Fix ICD LIT connected configurations
maciejbaczmanski Jul 15, 2024
7571735
[nrf toup][nrfconnect] Fix `zap-generate` `-o` path argument
maciejbaczmanski Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions config/zephyr/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,11 +390,11 @@ config CHIP_ICD_ACTIVE_MODE_THRESHOLD

config CHIP_ICD_LIT_SUPPORT
bool "Intermittenly Connected Device Long Idle Time support"
imply CHIP_ICD_CHECK_IN_SUPPORT
imply CHIP_ICD_UAT_SUPPORT
select CHIP_ICD_CHECK_IN_SUPPORT
select CHIP_ICD_UAT_SUPPORT
help
Enables the Intermittently Connected Device Long Idle Time support in Matter.
It also implies the ICD Check-In and UAT features support that are mandatory for LIT device.
It also selects the ICD Check-In and UAT features support that are mandatory for LIT device.

config CHIP_ICD_CHECK_IN_SUPPORT
bool "Intermittenly Connected Device Check-In protocol support"
Expand Down
5 changes: 2 additions & 3 deletions scripts/west/zap_generate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import os
import sys

from pathlib import Path
from textwrap import dedent

from west import log
Expand All @@ -33,7 +32,7 @@ def do_add_parser(self, parser_adder):
description=self.description)
parser.add_argument('-z', '--zap-file', type=existing_file_path,
help='Path to data model configuration file (*.zap)')
parser.add_argument('-o', '--output', type=Path,
parser.add_argument('-o', '--output', type=existing_dir_path,
help='Path where to store the generated files')
parser.add_argument('-m', '--matter-path', type=existing_dir_path,
default=DEFAULT_MATTER_PATH, help='Path to Matter SDK')
Expand All @@ -49,7 +48,7 @@ def do_run(self, args, unknown_args):
raise CommandError("No valid .zap file provided")

if args.output:
output_path = args.output
output_path = args.output.absolute()
else:
output_path = zap_file_path.parent / "zap-generated"

Expand Down
Loading