This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Control interface improvements #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixup!fixup! [nrf noup] zephyr: Add support for WPA CLI zephyr In case of failure from control interface, check and propagate the error to the caller. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
requested review from
jukkar,
rado17,
sachinthegreen and
rlubos
as code owners
jukkar
reviewed
Jan 26, 2024
This reverts commit a42ccc3. Closing socket on EoF is a proper behaviour, else we keep getting zero byte receives which are useless. The socket is now unusable. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
fixup! [nrf noup] zephyr: Add support for global control interface The below fixes from non-global control interface are ported: 1. Dummy receive in case of memory allocation failures 2. Identify EoF and close the socket. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
force-pushed
the
ctrl_iface_improvs
branch
from
deb6689
to
1364bae
Compare
sachinthegreen
approved these changes
Feb 1, 2024
krish2718
force-pushed
the
ctrl_iface_improvs
branch
from
1364bae
to
ca30af1
Compare
jukkar
reviewed
Feb 2, 2024
Relying on heap during OOM is bad, esp. for critical module like WPA supplicant, this can break the Wi-Fi. As the WPA supplicant stack is large enough and we have reduced the control interface sizes, move the buffers for control interface to stack or use static variable. The static variable is used to keep the changes to the common code of the WPA supplicant to a minimum compared to using stack. Fixes SHEL-2283. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
This can be same as non-global control interface, for interface command the output is limited to 1024. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
force-pushed
the
ctrl_iface_improvs
branch
from
ca30af1
to
4fe0c79
Compare
jukkar
approved these changes
Feb 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To handle OOM conditions in a SnS test (Stress and Stability) after few hours.