Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Control interface improvements #150

Merged
merged 5 commits into from
Feb 7, 2024

Commits on Jan 25, 2024

  1. [nrf noup] zephyr: Propagate the error from control interface

    fixup!fixup! [nrf noup] zephyr: Add support for WPA CLI zephyr
    
    In case of failure from control interface, check and propagate the error to the caller.
    
    Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
    krish2718 committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    b214299 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Revert "[nrf noup] zephyr: Fix handling of zero-byte receive"

    This reverts commit a42ccc3.
    
    Closing socket on EoF is a proper behaviour, else we keep getting zero
    byte receives which are useless. The socket is now unusable.
    
    Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
    krish2718 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    9cd64c8 View commit details
    Browse the repository at this point in the history
  2. [nrf noup] zephyr: Port fixes from non-global control interface

    fixup! [nrf noup] zephyr: Add support for global control interface
    
    The below fixes from non-global control interface are ported:
    
    1. Dummy receive in case of memory allocation failures
    2. Identify EoF and close the socket.
    
    Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
    krish2718 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    f40724e View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. [nrf noup] zephyr: Don't use heap for control interface

    Relying on heap during OOM is bad, esp. for critical module like WPA
    supplicant, this can break the Wi-Fi.
    
    As the WPA supplicant stack is large enough and we have reduced the
    control interface sizes, move the buffers for control interface to
    stack or use static variable.
    
    The static variable is used to keep the changes to the common code of
    the WPA supplicant to a minimum compared to using stack.
    
    Fixes SHEL-2283.
    
    Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
    krish2718 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    9c79021 View commit details
    Browse the repository at this point in the history
  2. [nrf noup] zephyr: Reduce the global control interface buffer

    This can be same as non-global control interface, for interface command
    the output is limited to 1024.
    
    Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
    krish2718 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    4fe0c79 View commit details
    Browse the repository at this point in the history