-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
application: serial_lte_modem: Allow auto-connect for NIDD #10840
Conversation
This PR is created for the required behavior in verifying FOTA over LwM2M with NIDD binding in SoftBank network. |
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
b5450b3
to
bb883dc
Compare
Hi @mgolu, is auto-connect to NIDD network acceptable to your customers? |
Overall this will work, since the auto-connect to NIDD is configurable via the new XCARRIER command. |
applications/serial_lte_modem/src/lwm2m_carrier/slm_at_carrier.c
Outdated
Show resolved
Hide resolved
The point is by default auto-connect is eanbled in the setting page, which is behavior change of SLM with NIDD. |
bb883dc
to
787a961
Compare
This seems like something that deserves a changelog entry, so remember to add one after this is no longer work in progress. |
acronym NIDD, which words it comes from? |
Non-IP Data Delivery (3GPP R13~) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this needs a changelog entry for the added AT command.
applications/serial_lte_modem/src/lwm2m_carrier/slm_at_carrier.c
Outdated
Show resolved
Hide resolved
832cd1b
to
92e8390
Compare
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
92e8390
to
fc1f0d9
Compare
fc1f0d9
to
b2420e2
Compare
If there is need to configure the PDP context, the user can always disable auto-connect and use AT commands to do so as they would do until now. I don't see why SLM would have specific handling for Non-IP binding, which in the LwM2M Carrier library's case is definitely the less common choice. If it's more convenient to set up the context in the code for NIDD, I would simply restrict that section of code to be conditional on CONFIG_LWM2M_CARRIER_SERVER_BINDING_N, but I do find it slightly odd for the SLM to have what seems like application-specific implementation. Setting the functional mode of the modem to 1 (CFUN=1) can apply regardless of the binding, and that can be made dependent on CONFIG_SLM_CARRIER, so this wouldn't affect the behaviour when SLM is built without carrierlib. |
applications/serial_lte_modem/src/lwm2m_carrier/slm_at_carrier.c
Outdated
Show resolved
Hide resolved
applications/serial_lte_modem/src/lwm2m_carrier/slm_at_carrier.c
Outdated
Show resolved
Hide resolved
I get your point. Something special with LwM2M_Carrier integration is that you enabled the PDN library in the overlay. This means that customer can add extra CONFIG defined by the library to configure LTE connection, upon libmodem is initialized by SLM main(). Then I'll use CONFIG_SLM_CARRIER to enclose the auto connection logic, which will contain CFUN=1 only. New solution tested good with Leshan (U-binding) and SoftBank IoTPF (N-binding) with two different overlays. |
b2420e2
to
aa87c0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and useful improvement, thanks 👍
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
d7e4cf2
to
1276b9b
Compare
} | ||
|
||
LOG_INF("auto connect"); | ||
#if defined(CONFIG_LWM2M_CARRIER_SERVER_BINDING_N) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the SYSTEMMODE setting has to be under CONFIG_LWM2M_CARRIER_SERVER_BINDING_N?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the SYSTEMMODE setting has to be under CONFIG_LWM2M_CARRIER_SERVER_BINDING_N?
Because modem only support NB-IoT for NIDD connection.
1276b9b
to
de175d2
Compare
For the use case of FOTA with lwm2m_carrier, .Enable auto-connect after FOTA image is applied. .Enable auto-connect on all kinds of reset. .Add AT#XCARRIER="auto-connect","read|write"[,<auto-connect-flag>] to control YES/NO of auto-connect. Dependence: libmodem v2.4.2 Signed-off-by: Jun Qing Zou <jun.qing.zou@nordicsemi.no>
de175d2
to
ff4a9f8
Compare
For the use case of FOTA over NIDD with lwm2m_carrier,
.Enable auto-connect NIDD after FOTA image is applied.
.Enable auto-connect NIDD on all kinds of reset.
.Add
AT#XCARRIER="auto-connect","read|write"[,<auto-connect-flag>]
to control YES/NO of auto-connect.Dependence: libmodem v2.4.2
UPDATE: the solution has been expanded to support both U-bind and N-bind for LwM2M_Carrier.