lib: Update identity_key and hw_uniq_key libraries to return error codes #11557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vge0rge
requested review from
oyvindronningstad,
SebastianBoe,
joerchan,
frkv,
hakonfam,
a team,
anangl and
rlubos
as code owners
github-actions
bot
added
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
Vge0rge
force-pushed
the
improve_identity_hw_key
branch
from
ff516df
to
29749bf
Compare
Vge0rge
force-pushed
the
improve_identity_hw_key
branch
from
29749bf
to
dd3b5e2
Compare
SebastianBoe
approved these changes
Jun 19, 2023
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
joerchan
suggested changes
Jun 19, 2023
Vge0rge
force-pushed
the
improve_identity_hw_key
branch
from
dd3b5e2
to
86fa6fe
Compare
github-actions
bot
removed
the
changelog-entry-required
Vge0rge
force-pushed
the
improve_identity_hw_key
branch
from
86fa6fe
to
36afb0f
Compare
lemrey
reviewed
Jun 19, 2023
lemrey
reviewed
Jun 19, 2023
mia-ko
requested changes
Jun 20, 2023
Vge0rge
force-pushed
the
improve_identity_hw_key
branch
from
36afb0f
to
5f4bfe7
Compare
mia-ko
reviewed
Jun 20, 2023
Vge0rge
force-pushed
the
improve_identity_hw_key
branch
2 times, most recently
from
cc934e9
to
25be3db
Compare
mia-ko
approved these changes
Jun 20, 2023
joerchan
reviewed
Jun 20, 2023
Vge0rge
force-pushed
the
improve_identity_hw_key
branch
from
25be3db
to
4c1e81c
Compare
|
@mia-ko I did some small changes in the changelog, could you check them please? |
joerchan
approved these changes
Jun 20, 2023
lemrey
approved these changes
Jun 20, 2023
mia-ko
requested changes
Jun 21, 2023
mia-ko
approved these changes
Jun 22, 2023
The identity key library until now panicked with k_panic in case of error in most of the cases. It is a preferred practice to return error codes and let the application decide what to do with the error. This updates the functions from void to int and adds some extra error codes to cover all the cases. Ref: NCSDK-21839 Signed-off-by: Georgios Vasilakis <georgios.vasilakis@nordicsemi.no>
The functionality of this sample is presented in other samples (see hw_unique_key) making it redundant. Signed-off-by: Georgios Vasilakis <georgios.vasilakis@nordicsemi.no>
The hardware unique key library until now panicked with k_panic in case of error in most of the cases. It is a preferred practice to return error codes and let the application decide what to do with the error. This updates the functions from void to int and adds some extra error codes to cover all the cases. Ref: NCSDK-21839 Signed-off-by: Georgios Vasilakis <georgios.vasilakis@nordicsemi.no>
Vge0rge
force-pushed
the
improve_identity_hw_key
branch
from
eadc800
to
c8ccbcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the two identity key and the hardware unique key libraries so that they don't panic but instead they return an error code. This will allow the application to handle the error as they seem fit.
Also removes the random_hw_unique_key sample since it is now redundant.
Ref: NCSDK-21839