application: serial_lte_modem: new nRF Cloud service #11573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junqingzou
requested review from
tejlmand,
SeppoTakalo,
VTPeltoketo,
MarkusLassila and
rlubos
as code owners
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
junqingzou
force-pushed
the
pr_new_nrf_cloud
branch
from
5c2dede
to
876cea0
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
junqingzou
force-pushed
the
pr_new_nrf_cloud
branch
from
876cea0
to
8b19916
Compare
github-actions
bot
added
doc-required
wiba-nordic
requested changes
Jun 21, 2023
junqingzou
force-pushed
the
pr_new_nrf_cloud
branch
from
8b19916
to
12dd8a9
Compare
junqingzou
commented
Jun 22, 2023
junqingzou
force-pushed
the
pr_new_nrf_cloud
branch
from
12dd8a9
to
dcb10da
Compare
wiba-nordic
previously requested changes
Jun 22, 2023
junqingzou
force-pushed
the
pr_new_nrf_cloud
branch
from
dcb10da
to
c5f2068
Compare
MarkusLassila
requested changes
Jun 28, 2023
junqingzou
force-pushed
the
pr_new_nrf_cloud
branch
from
c5f2068
to
8151760
Compare
github-actions
bot
added
the
changelog-entry-required
Separate nRF Cloud service from the GNSS service to allow include/exclude of nRF Cloud services by configurating prj.conf, and allow more nRF Cloud-specific services be added later. New configuration CONFIG_SLM_NRF_CLOUD for nRF Cloud access. nRF Cloud A-GPS, P-GPS and Location service to be configured separately with lib_nrfcloud configuration items: .Remove CONFIG_SLM_LOCATION, to use CONFIG_NRF_CLOUD_LOCATION. .Remove CONFIG_SLM_AGPS, to use CONFIG_NRF_CLOUD_AGPS. .Remove CONFIG_SLM_PGPS, to use CONFIG_NRF_CLOUD_PGPS. Enable nRF Cloud A-GPS and Location service by default. Signed-off-by: Jun Qing Zou <jun.qing.zou@nordicsemi.no>
|
@kacperradoszewski |
MarkusLassila
approved these changes
Jun 29, 2023
junqingzou
force-pushed
the
pr_new_nrf_cloud
branch
from
8151760
to
29b8e8d
Compare
kacperradoszewski
approved these changes
Jun 29, 2023
| @@ -0,0 +1,850 @@ | |||
| /* | |||
| * Copyright (c) 2021 Nordic Semiconductor ASA | |||
VTPeltoketo
approved these changes
Jun 29, 2023
|
@melwee01 Please help to review the docs on behalf of @wiba-nordic |
melwee01
approved these changes
Jul 3, 2023
junqingzou
dismissed
wiba-nordic’s stale review
all required doc changes have been addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate nRF Cloud service from the GNSS service to allow
include/exclude of nRF Cloud services by configurating prj.conf,
and allow more nRF Cloud-specific services be added later.
New configuration CONFIG_SLM_NRF_CLOUD for nRF Cloud access.
nRF Cloud A-GPS, P-GPS and Location service to be configured seperately with lib_nrfcloud configuration items:
.Remove CONFIG_SLM_LOCATION, to use CONFIG_NRF_CLOUD_LOCATION.
.Remove CONFIG_SLM_AGPS, to use CONFIG_NRF_CLOUD_AGPS.
.Remove CONFIG_SLM_PGPS, to use CONFIG_NRF_CLOUD_PGPS.
Enable nRF Cloud A-GPS and Location service by default.