nrf_security: Fix Legacy configuration for enabling SHA algorithms #11602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the kconfig_check_and_set_base_to_val_depends extension macro creating an inconsistent configuration. This macro sets the base name to, but not the kconfig name. For example: 'kconfig_check_and_set_base_to_val_depends(MBEDTLS_EXAMPLE_ALG, PSA_WANT_EXAMPLE_ALG)' can create this inconsistentency: CONFIG_PSA_WANT_EXAMPLE_ALG: true MBEDTLS_EXAMPLE_ALG: true CONFIG_MBEDTLS_EXAMPLE_ALG: false This means that the macro cannot be used to check a series of chained dependencies. Make sure that the macro modifies the value of both the base and the kconfig variable. Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
Re-order legacy cmake configuration force-enabling. This fixes the issue where PSA_WANT_ALG_SHA_256 enables MBEDTLS_SHA256 without enabling MBEDTLS_SHA224. This could otherwise lead to an error in check_config.h Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
joerchan
requested review from
frkv,
Vge0rge,
vili-nordic,
SebastianBoe and
mswarowsky
as code owners
github-actions
bot
added
the
changelog-entry-required
joerchan
changed the title
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
vili-nordic
approved these changes
Jun 22, 2023
mswarowsky
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the kconfig_check_and_set_base_to_val_depends extension macro
creating an inconsistent configuration.
This macro sets the base name to, but not the kconfig name.
For example:
'kconfig_check_and_set_base_to_val_depends(MBEDTLS_EXAMPLE_ALG,
PSA_WANT_EXAMPLE_ALG)' can create this inconsistentency:
CONFIG_PSA_WANT_EXAMPLE_ALG: true
MBEDTLS_EXAMPLE_ALG: true
CONFIG_MBEDTLS_EXAMPLE_ALG: false
This means that the macro cannot be used to check a series of chained
dependencies.
Make sure that the macro modifies the value of both the base and the
kconfig variable.
Re-order legacy cmake configuration force-enabling.
This fixes the issue where PSA_WANT_ALG_SHA_256 enables MBEDTLS_SHA256
without enabling MBEDTLS_SHA224.
This could otherwise lead to an error in check_config.h