Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nrf_security: Fix Legacy configuration for enabling SHA algorithms #11602

Merged
merged 2 commits into from
Jun 23, 2023
Merged

nrf_security: Fix Legacy configuration for enabling SHA algorithms #11602

merged 2 commits into from
Jun 23, 2023

Commits on Jun 22, 2023

  1. nrf_security: Fix kconfig extension macro inconsistent configuration 

    Fix the kconfig_check_and_set_base_to_val_depends extension macro
creating an inconsistent configuration.
This macro sets the base name to, but not the kconfig name.
For example:
'kconfig_check_and_set_base_to_val_depends(MBEDTLS_EXAMPLE_ALG,
PSA_WANT_EXAMPLE_ALG)' can create this inconsistentency:
CONFIG_PSA_WANT_EXAMPLE_ALG: true
MBEDTLS_EXAMPLE_ALG: true
CONFIG_MBEDTLS_EXAMPLE_ALG: false

This means that the macro cannot be used to check a series of chained
dependencies.

Make sure that the macro modifies the value of both the base and the
kconfig variable.

Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
    @joerchan
    joerchan committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    6bfd9b0 View commit details
    Browse the repository at this point in the history

  2. nrf_security: Re-order legacy cmake configuration force-enabling 

    Re-order legacy cmake configuration force-enabling.
This fixes the issue where PSA_WANT_ALG_SHA_256 enables MBEDTLS_SHA256
without enabling MBEDTLS_SHA224.
This could otherwise lead to an error in check_config.h

Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
    @joerchan
    joerchan committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    7ed20ed View commit details
    Browse the repository at this point in the history