net: nrf_provisioning: Change platform #11633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
juhaylinen
force-pushed
the
move_provisioning
branch
from
b5832eb
to
07bfea7
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
SeppoTakalo
approved these changes
Jun 29, 2023
jarlamsa
approved these changes
Jul 4, 2023
juhaylinen
removed
the
changelog-entry-required
juhaylinen
force-pushed
the
move_provisioning
branch
from
07bfea7
to
04621b6
Compare
github-actions
bot
added
the
changelog-entry-required
juhaylinen
changed the title
juhaylinen
removed
the
changelog-entry-required
Change platform to nrf9161dk Signed-off-by: Juha Ylinen <juha.ylinen@nordicsemi.no>
juhaylinen
force-pushed
the
move_provisioning
branch
from
04621b6
to
79c0b09
Compare
github-actions
bot
added
the
changelog-entry-required
| - nrf9160dk_nrf9160_ns | ||
| platform_allow: nrf9160dk_nrf9160_ns | ||
| - nrf9161dk_nrf9161_ns | ||
| platform_allow: nrf9161dk_nrf9161_ns |
There was a problem hiding this comment.
Shouldn't this sample support both nRF9160DK and nRF9161DK?
Suggested change
| platform_allow: nrf9161dk_nrf9161_ns | |
| platform_allow: nrf9160dk_nrf9160_ns nrf9161dk_nrf9161_ns |
nRF9160 could also be added to integration platforms to build both boards in CI.
There was a problem hiding this comment.
In my understanding device provisioning is not supported on 9160dk. @plskeggs should the sample support both boards?
juhaylinen
removed
the
changelog-entry-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change platform to nrf9161dk