Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: nrf_provisioning: Change platform #11633

Merged
merged 1 commit into from
Jul 7, 2023
Merged

net: nrf_provisioning: Change platform #11633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions samples/cellular/nrf_provisioning/sample.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ tests:
sample.cellular.nrf_provisioning:
build_only: true
integration_platforms:
- nrf9160dk_nrf9160_ns
platform_allow: nrf9160dk_nrf9160_ns
- nrf9161dk_nrf9161_ns
platform_allow: nrf9161dk_nrf9161_ns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this sample support both nRF9160DK and nRF9161DK?

Suggested change
platform_allow: nrf9161dk_nrf9161_ns
platform_allow: nrf9160dk_nrf9160_ns nrf9161dk_nrf9161_ns

nRF9160 could also be added to integration platforms to build both boards in CI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my understanding device provisioning is not supported on 9160dk. @plskeggs should the sample support both boards?