Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applications: nrf5340_audio: Expand SD card module #11642

Conversation

MariusVaardal
Copy link

To avoid unnecessary opening
and closing of files

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jun 28, 2023
@NordicBuilder
Copy link
Contributor

Thank you for your contribution!
It seems you are not a member of the nrfconnect GitHub organization. External contributions are handled as follows:
Large contributions, affecting multiple subsystems for example, may be rejected if they are complex, may introduce regressions due to lack of test coverage, or if they are not consistent with the architecture of nRF Connect SDK.
PRs will be run in our continuous integration (CI) test system.
If CI passes, PRs will be tagged for review and merged on successful completion of review. You may be asked to make some modifications to your contribution during review.
If CI fails, PRs may be rejected or may be tagged for review and rework.
PRs that become outdated due to other changes in the repository may be rejected or rework requested.
External contributions will be prioritized for review based on the relevance to current development efforts in nRF Connect SDK. Bug fix PRs will be prioritized.
You may raise issues or ask for help from our Technical Support team by visiting https://devzone.nordicsemi.com/.

Note: This comment is automatically posted and updated by the Contribs GitHub Action.

@NordicBuilder NordicBuilder added the external External contribution label Jun 28, 2023
@CLAassistant
Copy link

CLAassistant commented Jun 28, 2023

CLA assistant check
All committers have signed the CLA.

applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.h Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.h Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.h Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
@MariusVaardal MariusVaardal force-pushed the OCT-NONE-expand-sd-card-module branch 3 times, most recently from ba2d31f to 33ee830 Compare July 17, 2023 14:06
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.h Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.h Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.h Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
@MariusVaardal MariusVaardal force-pushed the OCT-NONE-expand-sd-card-module branch 3 times, most recently from b18023f to 3efea5f Compare July 28, 2023 07:08
@MariusVaardal MariusVaardal force-pushed the OCT-NONE-expand-sd-card-module branch from 3efea5f to 9aff801 Compare July 31, 2023 08:46
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.h Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.h Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.h Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.c Outdated Show resolved Hide resolved
@MariusVaardal MariusVaardal force-pushed the OCT-NONE-expand-sd-card-module branch from 9aff801 to d5b8952 Compare July 31, 2023 13:44
applications/nrf5340_audio/src/modules/sd_card.h Outdated Show resolved Hide resolved
applications/nrf5340_audio/src/modules/sd_card.h Outdated Show resolved Hide resolved
@MariusVaardal MariusVaardal force-pushed the OCT-NONE-expand-sd-card-module branch 3 times, most recently from de1959e to 2f08f0f Compare August 10, 2023 07:16
@koffes
Copy link
Contributor

koffes commented Aug 10, 2023

Change the static variable to a semaphore.

@koffes
Copy link
Contributor

koffes commented Aug 11, 2023

We are almost there. The semaphore cannot wait forever as this may cause the system to hang with no error message.
Suggest:
#define K_SEM_OPER_TIMEOUT_MS 500 and use this instead of K_FOREVER:

k_sem_take(&m_sem_sd_oper_ongoing, K_MSEC(K_SEM_OPER_TIMEOUT_MS));

@MariusVaardal MariusVaardal reopened this Aug 11, 2023
@MariusVaardal MariusVaardal reopened this Aug 11, 2023
@koffes koffes added the CI-Requested Approves single commit for CI tests on Internal HW label Aug 11, 2023
To avoid unnecessary opening
and closing of files

Signed-off-by: Marius Vårdal <marius.vardal@nordicsemi.no>
@github-actions github-actions bot removed the CI-Requested Approves single commit for CI tests on Internal HW label Aug 11, 2023
@koffes
Copy link
Contributor

koffes commented Aug 11, 2023

Replaced by: #12024

@koffes koffes closed this Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. CI-trusted-author The author of the PR is trusted. All future commits will be tested in PR. external External contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants