Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applications: nrf5340_audio: Expand SD card module #12024

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

mVaardal
Copy link
Contributor

To avoid unnecessary opening
and closing of files

@CLAassistant
Copy link

CLAassistant commented Aug 11, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 11, 2023
@NordicBuilder
Copy link
Contributor

Thank you for your contribution!
It seems you are not a member of the nrfconnect GitHub organization. External contributions are handled as follows:
Large contributions, affecting multiple subsystems for example, may be rejected if they are complex, may introduce regressions due to lack of test coverage, or if they are not consistent with the architecture of nRF Connect SDK.
PRs will be run in our continuous integration (CI) test system.
If CI passes, PRs will be tagged for review and merged on successful completion of review. You may be asked to make some modifications to your contribution during review.
If CI fails, PRs may be rejected or may be tagged for review and rework.
PRs that become outdated due to other changes in the repository may be rejected or rework requested.
External contributions will be prioritized for review based on the relevance to current development efforts in nRF Connect SDK. Bug fix PRs will be prioritized.
You may raise issues or ask for help from our Technical Support team by visiting https://devzone.nordicsemi.com/.

Note: This comment is automatically posted and updated by the Contribs GitHub Action.

@NordicBuilder NordicBuilder added the external External contribution label Aug 11, 2023
Copy link
Contributor

@koffes koffes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same code as in #11642

@koffes koffes added the CI-trusted-author The author of the PR is trusted. All future commits will be tested in PR. label Aug 11, 2023
@koffes koffes added the CI-Requested Approves single commit for CI tests on Internal HW label Aug 11, 2023
@github-actions github-actions bot removed the CI-Requested Approves single commit for CI tests on Internal HW label Aug 11, 2023
To avoid unnecessary opening
and closing of files

Signed-off-by: Marius Vårdal <marius.vardal@nordicsemi.no>
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 11, 2023

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-sdk-audio X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@mVaardal mVaardal force-pushed the OCT-NONE-expand-sd-card-module branch from ccf0edf to 5b90d4f Compare August 11, 2023 13:54
@koffes koffes added the CI-Requested Approves single commit for CI tests on Internal HW label Aug 11, 2023
@nordicjm nordicjm merged commit 63a1d9c into nrfconnect:main Aug 14, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. CI-Requested Approves single commit for CI tests on Internal HW CI-trusted-author The author of the PR is trusted. All future commits will be tested in PR. external External contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants