Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Driver ids #11695

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Driver ids #11695

merged 2 commits into from
Jul 5, 2023

Conversation

SebastianBoe
Copy link
Contributor

see commit messages

@SebastianBoe
nrf_security: Don't use the same ID as upstream
697663b 
Don't use ID 5 as it is used by vanilla TF-M for the driver
TFM_BUILTIN_KEY_LOADER and it is easier to use upstreams IDs as-is
than to patch them.

Use a large random ID as it is unlikely to conflict with anything.

Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
@SebastianBoe
nrf_security: Align with TF-M PSA driver IDs
68168f0 
TF-M defines TFM_BUILTIN_KEY_LOADER to have ID 5.

Use the same ID for the same driver to not diverge unnecessarily and
to reduce the likelihood of having conflicting IDs.

Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 4, 2023
@NordicBuilder
Copy link
Contributor

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-chip X
test-fw-nrfconnect-nrf-iot_cloud X
test-fw-nrfconnect-nrf-iot_zephyr_lwm2m X
test-fw-nrfconnect-nrf_crypto X
test-fw-nrfconnect-tfm X
test-sdk-find-my X
test-sdk-homekit X
test-sdk-wifi X
test-sdk-wifi-EK-shell X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@rlubos rlubos merged commit 4809525 into nrfconnect:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vge0rge Vge0rge Vge0rge approved these changes

@joerchan joerchan joerchan approved these changes

@frkv frkv Awaiting requested review from frkv

@vili-nordic vili-nordic Awaiting requested review from vili-nordic

@mswarowsky mswarowsky Awaiting requested review from mswarowsky

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SebastianBoe @NordicBuilder @joerchan @Vge0rge @rlubos