Bluetooth: Mesh: Recalculate regulator internal sum #11713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ble mesh
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
PavelVPV
force-pushed
the
recalc_reg_int_sum
branch
from
c301fe7
to
745fbb7
Compare
PavelVPV
changed the title
PavelVPV
force-pushed
the
recalc_reg_int_sum
branch
2 times, most recently
from
958bb79
to
90c5e6f
Compare
|
@omkar3141, please review. |
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
mia-ko
requested changes
Aug 7, 2023
omkar3141
approved these changes
Aug 17, 2023
PavelVPV
force-pushed
the
recalc_reg_int_sum
branch
from
90c5e6f
to
be9eee8
Compare
mia-ko
reviewed
Aug 17, 2023
PavelVPV
force-pushed
the
recalc_reg_int_sum
branch
from
be9eee8
to
10e4fce
Compare
mia-ko
approved these changes
Aug 17, 2023
ludvigsj
approved these changes
Aug 18, 2023
Use system time instead of mocking k_* functions. Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
After switching the controller tests to system time, the regulator test that checks regulator's wrap around behavior started taking too much time. Wisely hack the internal sum of the regulator to avoid long execution time. Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
Recalculate internal sum of the regulator to mitigate rapid change of the regulator output when lightness value is non zero. Add ramp up time to the pi regulator to artificially delay the regulator. Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
PavelVPV
force-pushed
the
recalc_reg_int_sum
branch
from
10e4fce
to
06a4de1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recalculate internal sum of the regulator to mitigate rapid change of
the regulator output when lightness value is non zero.
Add ramp up time to the pi regulator to artificially delay the
regulator.
This PR additionally changes light controller unit test to use system
time instead of mocking kernel functions to test the regulator with
the fsm.
Commits are split to make easier to see changes related to new behavior.