Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: matter: modify default configuration of Matter samples #11965

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

LuDuda
Copy link
Contributor

@LuDuda LuDuda commented Aug 7, 2023

This PR brings changes related to the default configuration of Matter:

  • disables BLE Gatt cache
  • enables NVS erase natively
  • disables OT shell

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. manifest labels Aug 7, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 7, 2023

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
matter nrfconnect/sdk-connectedhomeip@834a21b nrfconnect/sdk-connectedhomeip@8fab527 (master) nrfconnect/sdk-connectedhomeip@834a21bf..8fab527b

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 7, 2023

Test specification

CI/Jenkins/NRF

  • Skipped

CI/Jenkins/integration

  • Skipped

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@LuDuda LuDuda force-pushed the pr/kconfig-matter branch 3 times, most recently from d790ac3 to b8cd74e Compare August 9, 2023 19:55
@NordicBuilder NordicBuilder removed the DNM label Aug 9, 2023
@LuDuda LuDuda force-pushed the pr/kconfig-matter branch 2 times, most recently from 828b5ae to 12cad8a Compare August 10, 2023 09:32
@LuDuda LuDuda requested a review from greg-fer August 10, 2023 09:54
@@ -103,6 +103,9 @@ Matter

* Added a page about :ref:`ug_matter_device_optimizing_memory`.
* Fixed an IPC crash on nRF5340 when Zephyr's main thread takes a long time.
* Disabled OpenThread shell by default in Matter over Thread samples.
* Enabled :kconfig:option:`CHIP_FACTORY_RESET_ERASE_NVS` KConfig option by default, including for builds without factory data support.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Enabled :kconfig:option:`CHIP_FACTORY_RESET_ERASE_NVS` KConfig option by default, including for builds without factory data support.
* Enabled :kconfig:option:`CHIP_FACTORY_RESET_ERASE_NVS` Kconfig option by default, including for builds without factory data support.

Copy link
Contributor

@greg-fer greg-fer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one typo. Approving.

This PR brings changes related to the default configuration of Matter:
 - disables BLE Gatt cache
 - enables NVS erase natively
 - disables OT shell

Signed-off-by: Łukasz Duda <lukasz.duda@nordicsemi.no>
@github-actions github-actions bot removed the manifest label Aug 10, 2023
@LuDuda LuDuda merged commit a0209cc into nrfconnect:main Aug 10, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval. manifest-matter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants