Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: cellular: gnss: add support for nRF91x1 factory almanac #12030

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

tokangas
Copy link
Contributor

@tokangas tokangas commented Aug 14, 2023

Added support for nRF91x1 factory almanac. The new almanac file format also supports QZSS satellites.

Updated nRF9160 factory almanac.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 14, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 14, 2023

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-nrf-iot_positioning X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

Copy link
Contributor

@trantanen trantanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different timestamps (although just one day) on different almanac versions may raise questions.

@tokangas
Copy link
Contributor Author

tokangas commented Aug 14, 2023

Different timestamps (although just one day) on different almanac versions may raise questions.

@trantanen That's how it currently is, the almanacs are generated on different days. If this is seen as a problem, we need to discuss with JP.

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Aug 14, 2023
@tokangas tokangas requested a review from peknis August 14, 2023 12:15
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@tokangas tokangas changed the title samples: cellular: gnss: add support for nRF9161 factory almanac samples: cellular: gnss: add support for nRF91x1 factory almanac Aug 15, 2023
Added support for nRF91x1 factory almanac. The new almanac file
format also supports QZSS satellites.

Updated nRF9160 factory almanac.

Signed-off-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
@nordicjm nordicjm merged commit 51414dd into nrfconnect:main Aug 15, 2023
12 checks passed
@tokangas tokangas deleted the gnss_factory_almanac_v3 branch August 15, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants