Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update application and sample documentation that support nRF9161 #12120

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

divipillai
Copy link
Contributor

Support of nRF9161 was added to following
applications and samples as part of
#11308:

Asset tracker application
Serial LTE modem application
Memfault sample
Https_client sample
Modem shell sample

This PR updates the documentation of these application and samples.

@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. labels Aug 23, 2023
@divipillai divipillai added CI-disable Disable CI for this PR and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Aug 23, 2023
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@divipillai
Copy link
Contributor Author

@SeppoTakalo @VTPeltoketo @MarkusLassila : Please confirm if updates are correct for Serial LTE modem application documentation. Also, any more updates are required with respect to nRF9161 for the application documentation.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 24, 2023
@divipillai divipillai force-pushed the NCSDK-22133_nrf9161_samples branch 2 times, most recently from b7c91d9 to 6851521 Compare August 24, 2023 12:16
@wiba-nordic
Copy link
Contributor

Prompted by #12173, but Asset Tracker and Serial LTE Modem should also change the corresponding headers in known_issues.rst and release-notes-changelog.rst to match the new page titles. Both can also add a new bullet as the first on on their list:
* Renamed [old name] to [new name].

@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Sep 1, 2023
@divipillai
Copy link
Contributor Author

Prompted by #12173, but Asset Tracker and Serial LTE Modem should also change the corresponding headers in known_issues.rst and release-notes-changelog.rst to match the new page titles. Both can also add a new bullet as the first on on their list: * Renamed [old name] to [new name].

@wiba-nordic : I have made changes to the change log and Known Issue pages. Since the rename is only at the documentation level and not an overall application rename, the * Renamed [old name] to [new name]. is not added to the pages. 

I have added a changelog entry about nRF9161 support to these applications. Please note that since all the cellular samples will have nRF9161 support, a changelog entry for cellular samples will be added in the PR: #12062

Support of nRF9161 was added to following
applications and samples as part of
nrfconnect#11308:

Asset tracker application
Serial LTE modem application
Memfault sample
Https_client sample
Modem shell sample

This PR updates the documentation of these application
and samples.

Signed-off-by: divya pillai <divya.pillai@nordicsemi.no>
@anangl anangl merged commit ced6667 into nrfconnect:main Sep 13, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-disable Disable CI for this PR doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.