Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applications: serial_lte_modem: update sample.yaml #12173

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

eivindj-nordic
Copy link
Contributor

Update sample.yaml
NCSDK-23316

@eivindj-nordic eivindj-nordic self-assigned this Aug 30, 2023
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 30, 2023
@eivindj-nordic eivindj-nordic added this to the 2.5.0 milestone Aug 30, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 30, 2023

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-nrf-iot_serial_lte_modem X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

Copy link
Contributor

@tomi-font tomi-font left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

tests:
applications.nrf9160.serial_lte_modem:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also want to remove nRF9160 from the name of the app in the docs?
I see 9161 is in platform_allow, so having nRF9160 in the app name might be a thing outdated.
https://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/nrf/applications/serial_lte_modem/README.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we do want to remove mentions of nRF9160.
See a related PR: #12120

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rename this to nRF91 Series.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, but #12120 uses just "Serial LTE modem", so I think @eivindj-nordic that "nRF91 Series" in the doc title is not needed.

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Aug 30, 2023
@tomi-font tomi-font removed the doc-required PR must not be merged without tech writer approval. label Aug 30, 2023
@@ -1,15 +1,15 @@
sample:
name: serial lte modem sample
name: Serial LTE Modem application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Serial LTE Modem application
name: Serial LTE Modem

Comment on lines 3 to 4
nRF91 Series: Serial LTE modem
##############################
Copy link
Contributor

@greg-fer greg-fer Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nRF91 Series: Serial LTE modem
##############################
Serial LTE Modem
################

To match #12120 and the capitalization of the first line of the document.

@greg-fer
Copy link
Contributor

FYI, @wiba-nordic .

@wiba-nordic
Copy link
Contributor

I think that since we already have a PR for changing the docs part, better to make all of those changes there and keep this one just for the yaml file.

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

Update application sample.yaml

Signed-off-by: Eivind Jølsgard <eivind.jolsgard@nordicsemi.no>
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 30, 2023
@eivindj-nordic
Copy link
Contributor Author

I think that since we already have a PR for changing the docs part, better to make all of those changes there and keep this one just for the yaml file.

Agreed, I'll drop the changes to the docs for this one.

@wiba-nordic wiba-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 30, 2023
@nordicjm nordicjm merged commit 971450d into nrfconnect:main Aug 30, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants