-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
applications: serial_lte_modem: update sample.yaml #12173
Conversation
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
tests: | ||
applications.nrf9160.serial_lte_modem: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you also want to remove nRF9160 from the name of the app in the docs?
I see 9161 is in platform_allow, so having nRF9160 in the app name might be a thing outdated.
https://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/nrf/applications/serial_lte_modem/README.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we do want to remove mentions of nRF9160.
See a related PR: #12120
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rename this to nRF91 Series
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, but #12120 uses just "Serial LTE modem", so I think @eivindj-nordic that "nRF91 Series" in the doc title is not needed.
f23026c
to
5408575
Compare
@@ -1,15 +1,15 @@ | |||
sample: | |||
name: serial lte modem sample | |||
name: Serial LTE Modem application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: Serial LTE Modem application | |
name: Serial LTE Modem |
nRF91 Series: Serial LTE modem | ||
############################## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nRF91 Series: Serial LTE modem | |
############################## | |
Serial LTE Modem | |
################ |
To match #12120 and the capitalization of the first line of the document.
FYI, @wiba-nordic . |
I think that since we already have a PR for changing the docs part, better to make all of those changes there and keep this one just for the yaml file. |
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
Update application sample.yaml Signed-off-by: Eivind Jølsgard <eivind.jolsgard@nordicsemi.no>
5408575
to
45065ba
Compare
Agreed, I'll drop the changes to the docs for this one. |
Update sample.yaml
NCSDK-23316