Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applications: serial_lte_modem: update sample.yaml #12173

Merged
merged 1 commit into from
Aug 30, 2023
Merged

applications: serial_lte_modem: update sample.yaml #12173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions applications/serial_lte_modem/sample.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
sample:
name: serial lte modem sample
name: Serial LTE Modem
tests:
applications.nrf9160.serial_lte_modem:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also want to remove nRF9160 from the name of the app in the docs?
I see 9161 is in platform_allow, so having nRF9160 in the app name might be a thing outdated.
https://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/nrf/applications/serial_lte_modem/README.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we do want to remove mentions of nRF9160.
See a related PR: #12120

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rename this to nRF91 Series.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, but #12120 uses just "Serial LTE modem", so I think @eivindj-nordic that "nRF91 Series" in the doc title is not needed.

applications.serial_lte_modem:
build_only: true
platform_allow: nrf9160dk_nrf9160_ns nrf9161dk_nrf9161_ns thingy91_nrf9160_ns
integration_platforms:
- nrf9160dk_nrf9160_ns
- nrf9161dk_nrf9161_ns
- thingy91_nrf9160_ns
tags: ci_build
applications.nrf9160.serial_lte_modem.native_tls:
applications.serial_lte_modem.native_tls:
build_only: true
extra_args: OVERLAY_CONFIG=overlay-native_tls.conf
platform_allow: nrf9160dk_nrf9160_ns nrf9161dk_nrf9161_ns thingy91_nrf9160_ns
Expand All @@ -18,7 +18,7 @@ tests:
- nrf9161dk_nrf9161_ns
- thingy91_nrf9160_ns
tags: ci_build
applications.nrf9160.serial_lte_modem.lwm2m_carrier:
applications.serial_lte_modem.lwm2m_carrier:
build_only: true
extra_args: OVERLAY_CONFIG=overlay-carrier.conf
platform_allow: nrf9160dk_nrf9160_ns nrf9161dk_nrf9161_ns thingy91_nrf9160_ns
Expand Down
Loading