Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: redistributing: use latest tag for Golioth #12551

Closed

Conversation

szczys
Copy link
Contributor

@szczys szczys commented Oct 5, 2023

Updated the links to the Golioth Zephyr SDK to use the latest v0.11.0 release.

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. labels Oct 5, 2023
@NordicBuilder
Copy link
Contributor

Thank you for your contribution!
It seems you are not a member of the nrfconnect GitHub organization. External contributions are handled as follows:
Large contributions, affecting multiple subsystems for example, may be rejected if they are complex, may introduce regressions due to lack of test coverage, or if they are not consistent with the architecture of nRF Connect SDK.
PRs will be run in our continuous integration (CI) test system.
If CI passes, PRs will be tagged for review and merged on successful completion of review. You may be asked to make some modifications to your contribution during review.
If CI fails, PRs may be rejected or may be tagged for review and rework.
PRs that become outdated due to other changes in the repository may be rejected or rework requested.
External contributions will be prioritized for review based on the relevance to current development efforts in nRF Connect SDK. Bug fix PRs will be prioritized.
You may raise issues or ask for help from our Technical Support team by visiting https://devzone.nordicsemi.com/.

Note: This comment is automatically posted and updated by the Contribs GitHub Action.

@NordicBuilder NordicBuilder added the external External contribution label Oct 5, 2023
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

Copy link
Contributor

@wiba-nordic wiba-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, but I'll let @gregersrygg give the approval.

Copy link
Contributor

@gregersrygg gregersrygg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wiba-nordic It looks fine to me, but I've never used Golioth. So it's probably better if someone with better knowledge of this can look at it.

@wiba-nordic
Copy link
Contributor

From what I can tell, we use Golioth as an example on this page: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/nrf/releases_and_maturity/developing/ncs_distro.html#redistributing-the-ncs

It is referenced as an example for providing a Zephyr module and for providing a west manifest. Since it's just the links that are changing here, I would assume we're good to accept this.

Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Dec 23, 2023
@szczys
Copy link
Contributor Author

szczys commented Dec 23, 2023

This should not be marked as stale. Is there anything we need to do to get this merged?

@github-actions github-actions bot removed the Stale label Dec 24, 2023
@wiba-nordic wiba-nordic added CI-disable Disable CI for this PR and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jan 2, 2024
Copy link

github-actions bot commented Mar 4, 2024

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Mar 4, 2024
@nordicjm
Copy link
Contributor

Rebase needed

Updated the links to the Golioth Zephyr SDK to use the latest v0.11.0
release.

Signed-off-by: Mike Szczys <mike@golioth.io>
@szczys szczys force-pushed the doc_redistributing_update_golioth_links branch from f01b156 to 73bce81 Compare March 15, 2024 16:49
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 15, 2024
@szczys
Copy link
Contributor Author

szczys commented Mar 15, 2024

@nordicjm thanks for the nudge. I've rebased and updated the tag number to match our latest release.

@github-actions github-actions bot removed the Stale label Mar 16, 2024
@wiba-nordic wiba-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 18, 2024
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-disable Disable CI for this PR doc-required PR must not be merged without tech writer approval. external External contribution Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants