-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: flpr and building for nrf54l15 #17443
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:more detailsGithub labels
List of changed files detected by CI (0)
Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
8ac9c2d
to
88efafa
Compare
88efafa
to
5064400
Compare
5064400
to
6ba875e
Compare
d00a133
to
806dc5a
Compare
806dc5a
to
e02dbf5
Compare
7dbbb34
to
556ca55
Compare
556ca55
to
7f0913c
Compare
702e1b8
to
e04ce36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mention of VPR Launcher is confusing to me. I think it is a mistake to call a sample that uses a snippet with a proper name that suggests it is a sort of external tool. See my comments for more issues around this.
|
||
.. group-tab:: Using VPR Launcher | ||
|
||
VPR launcher is a minimal sample that allows to start the FLPR core. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VPR launcher is a minimal sample built for an ARM core that starts given VPR core.
This is what https://github.com/zephyrproject-rtos/zephyr/blob/main/soc/nordic/common/vpr/Kconfig.sysbuild#L9-L11 from @masz-nordic states. With the comment from @wbober ("This is not a sample per se."), the Kconfig description is clearly wrong and needs to be fixed.
To be honest, I don't think we should use the name "VPR launcher" at all - not here nor in the Kconfig.
For me, the name suggests an external app or a tool. I can imagine some users will have a similar idea.
If it is a minimal sample with a snippet, it is clearly not a tool or an external app.
The current edit ("VPR launcher allows to start the FLPR core.") is unfortunately not addressing my original comment anymore because it doesn't provide a clear definition.
Please change this before merging this PR.
e04ce36
to
6aef9cb
Compare
5b5a069
to
00fc0d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three nits.
00fc0d3
to
b588bfe
Compare
Adds building article Adds FLPR intro Signed-off-by: Anna Wojdylo <anna.wojdylo@nordicsemi.no>
b588bfe
to
01ab255
Compare
Adds building article
Adds FLPR intro