Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect localisation sync issues for password requirements #3606

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

denysoblohin-okta
Copy link
Contributor

@denysoblohin-okta denysoblohin-okta commented Apr 18, 2024

Description:

SIW has a logic to remove translated part of password complexity requirements from server error response:

fn.removeRequirementsFromError = function(responseJSON, policy) {
const passwordRequirementsAsString = this.getPasswordComplexityDescription(policy);
if (
responseJSON.errorCauses &&
responseJSON.errorCauses.length > 0 &&
_.isString(responseJSON.errorCauses[0].errorSummary)
) {
responseJSON.errorCauses[0].errorSummary = responseJSON.errorCauses[0].errorSummary
.replace(passwordRequirementsAsString, '')
.trim();
}
return responseJSON;
};

But some translations are not in sync.
This PR adds a script to verify and/or fix translations issues.

yarn verify-translations
yarn verify-translations --write

PR Checklist

Issue:

Reviewers:

Screenshot/Video:

Downstream Monolith Build:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant