Enable e2e tests on SauceLabs in IE11 for Gen3 and Gen2 #3669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,10 +2,16 @@ | |||
| const path = require('path'); | |||
| require('@okta/env').config(); | |||
|
|
|||
| // You can use Firefox for e2e testing locally if there is an issue with `chromedriver` | |||
| // You need to have `geckodriver` process running (https://github.com/mozilla/geckodriver/releases) | |||
| const USE_FIREFOX = !!process.env.USE_FIREFOX; | |||
There was a problem hiding this comment.
Added Firefox support for local testing due to issues with chromedriver (drivers for Chrome 115+ moved to new URL so need to update wdio/* to support new Chtome locally)
denysoblohin-okta
force-pushed
the
od-e2e-gen3-ie11-OKTA-738533
branch
from
90eced0
to
d57fa0c
Compare
| @@ -39,9 +41,7 @@ export TARGET="CROSS_BROWSER" | |||
| export USE_MIN=1 | |||
| if ! yarn test:e2e; then | |||
| echo "e2e saucelabs test failed! Exiting..." | |||
| exit ${TEST_FAILURE} | |||
| exit ${PUBLISH_TYPE_AND_RESULT_DIR_BUT_ALWAYS_FAIL} | |||
There was a problem hiding this comment.
To save screenshots on fail
| }); | ||
|
|
||
| After(async () => { | ||
| await browser.deleteCookies(); |
There was a problem hiding this comment.
It makes more sense to move cookies deletion after logout
build only gen3 test only ie11 test 1 only test - should fail on IE11 test signup flow test all flows w/o ie.ensureCleanSession fix? revert clear session test1 test2 test retry test - no logout reloadSession remove retry await saveScreenshot + catch restore logout + secreenshot test - only resetPassword all flows fix remove reloadsession enable safari and edge fix iPad and timeouts add browserName to creenshot name enbale gen3 @ ipad log screenshot error reloadSession @ before specFileRetries: 1, clean
denysoblohin-okta
force-pushed
the
od-e2e-gen3-ie11-OKTA-738533
branch
2 times, most recently
from
7bc91ac
to
5193295
Compare
try timeouts try driver version test avoidProxy: true .
denysoblohin-okta
force-pushed
the
od-e2e-gen3-ie11-OKTA-738533
branch
from
e3c7922
to
558dc82
Compare
| @@ -6,11 +6,13 @@ source $OKTA_HOME/$REPO/scripts/setup.sh | |||
| setup_service java 1.8.222 | |||
| setup_service google-chrome-stable 89.0.4389.72-1 | |||
|
|
|||
| export RUN_SAUCE_TESTS=true | |||
| export RUN_SAUCE_TESTS=ie11,edge | |||
There was a problem hiding this comment.
RUN_SAUCE_TESTS can be list of ie11, edge, mobile separated with ,
mobile is not included here (and ine2e-saucelabs-v3 as well) because it's flaky (iPad can show "Let's browse!" message for localhost instead of rendering test app), and there is a separate Bacon test named e2e-saucelabs-mobile that runs tests specially for mobile platforms
Question: do we need edge? Since MS Edge is based on Chromium.
Revert "removed java and chrome for saucelab tests" This reverts commit 10a0791. removed chrome from saucelabs
denysoblohin-okta
force-pushed
the
od-e2e-gen3-ie11-OKTA-738533
branch
from
10a0791
to
6523a5b
Compare
denysoblohin-okta
changed the title
denysoblohin-okta
force-pushed
the
od-e2e-gen3-ie11-OKTA-738533
branch
from
a34a470
to
c45b0d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
PR Checklist
Issue:
Reviewers:
Screenshot/Video:
Downstream Monolith Build: