Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable e2e tests on SauceLabs in IE11 for Gen3 and Gen2 #3669
Enable e2e tests on SauceLabs in IE11 for Gen3 and Gen2 #3669
Changes from all commits
68dccbb
4375827
4f3144b
283936d
3fe7980
6ad564d
d9f775b
809c8e0
ef7f340
62f6f67
b37bf42
4eaa8dc
8ef1c65
4d568c9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUN_SAUCE_TESTS
can be list ofie11
,edge
,mobile
separated with,
mobile
is not included here (and ine2e-saucelabs-v3
as well) because it's flaky (iPad can show "Let's browse!" message for localhost instead of rendering test app), and there is a separate Bacon test namede2e-saucelabs-mobile
that runs tests specially for mobile platformsQuestion: do we need
edge
? Since MS Edge is based on Chromium.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can leave it
edge
on the listThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean remove
ie11
and leave onlyedge
?But then we lose ability to easily detect IE11 regressions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To save screenshots on fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restored this test, but it's flaky, so marked all
e2e-saucelabs*
Bacon tasks asOPTIONAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes more sense to move cookies deletion after logout