Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify spec for QUEUE_INFO_SIZE and change testing for it accordingly. #1128

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Clarify spec for QUEUE_INFO_SIZE and change testing for it accordingly. #1128

merged 2 commits into from
Jun 12, 2024

Conversation

aarongreig
Copy link
Contributor

@aarongreig aarongreig commented Nov 27, 2023 •
edited
Loading

LLVM testing intel/llvm#12269

@aarongreig aarongreig requested review from a team as code owners November 27, 2023 16:16
@aarongreig aarongreig requested review from a team as code owners November 28, 2023 10:41
@aarongreig aarongreig force-pushed the aaron/clarifyQueueInfoSize branch 3 times, most recently from c2926c9 to 1e8f8c9 Compare November 28, 2023 13:53
@fabiomestre fabiomestre changed the base branch from adapters to main December 5, 2023 16:45
@fabiomestre
Copy link
Contributor

I have updated the target branch of this PR from the adapters branch to the main branch.
Development in UR is moving back to main. The adapters branch will soon be deleted.

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023 •
edited
Loading

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (f15234d) 14.83% compared to head (f724434) 12.71%.
Report is 7 commits behind head on main.

Files Patch % Lines
test/conformance/queue/urQueueGetInfo.cpp 0.00% 27 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1128      +/-   ##
==========================================
- Coverage   14.83%   12.71%   -2.12%     
==========================================
  Files         250      238      -12     
  Lines       36232    35364     -868     
  Branches     4097     4014      -83     
==========================================
- Hits         5376     4498     -878     
- Misses      30805    30862      +57     
+ Partials       51        4      -47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aarongreig aarongreig force-pushed the aaron/clarifyQueueInfoSize branch 2 times, most recently from 3227899 to ef0c779 Compare December 29, 2023 10:29
@aarongreig aarongreig mentioned this pull request Dec 29, 2023
Merged
@aarongreig aarongreig mentioned this pull request Dec 29, 2023
Merged
@aarongreig aarongreig force-pushed the aaron/clarifyQueueInfoSize branch 3 times, most recently from 299e284 to ebcd8d3 Compare January 5, 2024 13:05
@aarongreig
Copy link
Contributor Author

ping @oneapi-src/unified-runtime-opencl-write @oneapi-src/unified-runtime-cuda-write @oneapi-src/unified-runtime-hip-write

@aarongreig aarongreig mentioned this pull request Feb 12, 2024
Open
@aarongreig aarongreig force-pushed the aaron/clarifyQueueInfoSize branch 3 times, most recently from 9511a3a to af16056 Compare February 13, 2024 12:08
@aarongreig aarongreig requested a review from a team as a code owner February 13, 2024 12:08
@kbenzie kbenzie added conformance Conformance test suite issues. specification Changes or additions to the specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues hip HIP adapter specific issues opencl OpenCL adapter specific issues native-cpu Native CPU adapter specific issues labels Apr 10, 2024
@github-actions github-actions bot added the loader Loader related feature/bug label May 7, 2024
@kbenzie kbenzie removed the request for review from a team May 30, 2024 09:52
@kbenzie kbenzie removed native-cpu Native CPU adapter specific issues level-zero L0 adapter specific issues labels May 30, 2024
@aarongreig @kbenzie
Clarify spec for QUEUE_INFO_SIZE and change testing for it accordingly.
51900ae 
Also correctly report lack of queue on device support in cuda and hip
adapters.
@aarongreig @kbenzie
Only test DEVICE_DEFAULT query when queue is device default.
41763be 
Some supported CL drivers return an error rather than NULL if you try
this query on a queue that wasn't created with the ON_DEVICE and
DEVICE_DEFAULT flags. This isn't correct according to the CL spec but
limiting our testing to the supported case is still preferable to adding
an exception to the match files.
@kbenzie kbenzie force-pushed the aaron/clarifyQueueInfoSize branch from c4da51a to 41763be Compare May 30, 2024 10:01
@kbenzie kbenzie requested a review from GeorgeWeb May 30, 2024 11:03
@kbenzie
Copy link
Contributor

kbenzie commented May 30, 2024

@GeorgeWeb would be great if you could give this a review, seems like this predates the automatic reviewer team assignment being enabled.

GeorgeWeb
GeorgeWeb approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@GeorgeWeb GeorgeWeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took so long to notice this one. Cuda and HIP adapters look good.

@kbenzie kbenzie added the ready to merge Added to PR's which are ready to merge label May 31, 2024
@kbenzie kbenzie merged commit 78d0203 into oneapi-src:main Jun 12, 2024
51 checks passed
steffenlarsen pushed a commit to intel/llvm that referenced this pull request Jun 12, 2024
@aarongreig @kbenzie
[UR] Bump main tag to 78d02039 (#12269)
7c530e1 
oneapi-src/unified-runtime#1128

---------

Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
ianayl pushed a commit to ianayl/sycl that referenced this pull request Jun 13, 2024
@aarongreig @kbenzie @ianayl
[UR] Bump main tag to 78d02039 (intel#12269)
8e445ed 
oneapi-src/unified-runtime#1128

---------

Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbenzie kbenzie kbenzie left review comments

@jandres742 jandres742 jandres742 approved these changes

@GeorgeWeb GeorgeWeb GeorgeWeb approved these changes

Assignees
No one assigned
Labels
conformance Conformance test suite issues. cuda CUDA adapter specific issues hip HIP adapter specific issues loader Loader related feature/bug opencl OpenCL adapter specific issues ready to merge Added to PR's which are ready to merge specification Changes or additions to the specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aarongreig @fabiomestre @codecov-commenter @kbenzie @GeorgeWeb @jandres742