Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump UMF version and switch to dynamic linking #1430

Merged
merged 6 commits into from
Jul 25, 2024

Conversation

igchor
Copy link
Member

@igchor igchor commented Mar 11, 2024

No description provided.

@pbalcer
Copy link
Contributor

pbalcer commented Mar 12, 2024

Let's target these changes for after 0.9.

@igchor
Copy link
Member Author

igchor commented Mar 12, 2024

Let's target these changes for after 0.9.

Sure, I just wanted to create a PR to do some initial testing

@igchor igchor force-pushed the umf_dynamic_linking branch 4 times, most recently from 068045f to ab7ce78 Compare March 14, 2024 02:51
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 12.49%. Comparing base (78ef1ca) to head (beef35a).
Report is 153 commits behind head on main.

Files Patch % Lines
source/common/umf_helpers.hpp 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1430      +/-   ##
==========================================
- Coverage   14.82%   12.49%   -2.33%     
==========================================
  Files         250      239      -11     
  Lines       36220    36000     -220     
  Branches     4094     4086       -8     
==========================================
- Hits         5369     4498     -871     
- Misses      30800    31498     +698     
+ Partials       51        4      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@igchor igchor force-pushed the umf_dynamic_linking branch 7 times, most recently from 664b7a1 to beef35a Compare March 16, 2024 01:42
@igchor igchor force-pushed the umf_dynamic_linking branch 7 times, most recently from ddab02b to a3776e5 Compare March 26, 2024 19:05
@igchor igchor force-pushed the umf_dynamic_linking branch 3 times, most recently from e4b1d3b to 29d3e31 Compare April 1, 2024 18:05
@igchor igchor marked this pull request as ready for review April 1, 2024 18:57
@igchor igchor requested review from a team as code owners April 1, 2024 18:57
@kswiecicki kswiecicki force-pushed the umf_dynamic_linking branch 6 times, most recently from 8462b60 to fc40d13 Compare July 24, 2024 10:14
@pbalcer pbalcer added the v0.10.x Include in the v0.10.x release label Jul 24, 2024
@kswiecicki kswiecicki force-pushed the umf_dynamic_linking branch 2 times, most recently from 108abe2 to d15fe0d Compare July 24, 2024 13:22
@igchor
Copy link
Member Author

igchor commented Jul 25, 2024

@kbenzie we have confirmation that intel/llvm is ready for the change: intel/llvm#13343 (review)
@kswiecicki please bump the UR tag once oneapi-src/unified-memory-framework#633 is merged and add ready to merge label

@kswiecicki kswiecicki force-pushed the umf_dynamic_linking branch 2 times, most recently from 233c07c to c10ff81 Compare July 25, 2024 09:16
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kswiecicki kswiecicki added the ready to merge Added to PR's which are ready to merge label Jul 25, 2024
@ldrumm
Copy link
Contributor

ldrumm commented Jul 25, 2024

This patch does more than two things and has no description.

Why are we switching to dynamic linking?
To which version are we bumping?
Which parts of the code changes are really required by the bump, and which are in-passing code cleanups?

Right now this patch does everything without rationale. Please split it more logically if you can, remove the fly-by changes, and provide us with a description of what justifies such changes

@pbalcer
Copy link
Contributor

pbalcer commented Jul 25, 2024

Why are we switching to dynamic linking?

Because that's how UMF is meant to ship with the compiler by default. This has been discussed with the compiler team.

To which version are we bumping?

We are switching to what will become UMF version for the next release.

Which parts of the code changes are really required by the bump, and which are in-passing code cleanups?

All parts of this patch are required to bump up the UMF version. The actual code changes are all very minor fixes required for everything to compile after UMF interface changes. There are no cleanup or feature changes at all here.

@pbalcer pbalcer merged commit 3d8fe8d into oneapi-src:main Jul 25, 2024
58 of 61 checks passed
steffenlarsen added a commit to intel/llvm that referenced this pull request Jul 26, 2024
Testing PR for: oneapi-src/unified-runtime#1430

---------

Co-authored-by: Krzysztof Swiecicki <krzysztof.swiecicki@intel.com>
Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
hdelan pushed a commit to hdelan/llvm that referenced this pull request Jul 26, 2024
Testing PR for: oneapi-src/unified-runtime#1430

---------

Co-authored-by: Krzysztof Swiecicki <krzysztof.swiecicki@intel.com>
Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
pbalcer added a commit to pbalcer/unified-runtime that referenced this pull request Jul 26, 2024
…nking"

This reverts commit 3d8fe8d, reversing
changes made to e8c9f3d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continuous integration/devliery common Changes or additions to common utilities conformance Conformance test suite issues. cuda CUDA adapter specific issues hip HIP adapter specific issues level-zero L0 adapter specific issues native-cpu Native CPU adapter specific issues opencl OpenCL adapter specific issues ready to merge Added to PR's which are ready to merge v0.10.x Include in the v0.10.x release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants