[UR] Automatically generate ur_structure_type_t #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbenzie
approved these changes
Jul 4, 2023
pbalcer
reviewed
Jul 4, 2023
scripts/parse_specs.py
Outdated
| @@ -914,6 +969,9 @@ def parse(section, version, tags, meta, ref): | |||
| }) | |||
|
|
|||
| specs = sorted(specs, key=lambda s: s['header']['ordinal']) | |||
| _inline_extended_structs(specs, meta) | |||
| registry = [f for f in files if f.endswith('registry.yml')][0] | |||
| _generate_structure_type_t(specs, meta, registry) | |||
There was a problem hiding this comment.
I'm not sure if I understand why this can't simply be a part of the generate_registry function. Right now it's called almost immediately after.
There was a problem hiding this comment.
Perhaps an artifact of a previous iteration of this change when it was generating a separate file?
There was a problem hiding this comment.
To generate the structure type we need to inline the extended structs, which happens after generate_registry, but since registry does not depend on this we could run these steps together after _inline_extended_structs
There was a problem hiding this comment.
@pbalcer I've refactored this so now the entire registry.yml file is generated together.
veselypeta
force-pushed
the
petr/563/structure_type
branch
from
e4ca6a6
to
20ba1e5
Compare
veselypeta
force-pushed
the
petr/563/structure_type
branch
from
20ba1e5
to
2f73f77
Compare
pbalcer
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR automatically generates $x_structure_type_t enumerations.