[UR] Check for if handle when type is complete #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
reviewed
Aug 3, 2023
veselypeta
force-pushed
the
petr/serialize-handles-when-complete
branch
3 times, most recently
from
3d286f7
to
1d50e0f
Compare
pbalcer
reviewed
Aug 4, 2023
[UR] Remove is_type_complete check
veselypeta
force-pushed
the
petr/serialize-handles-when-complete
branch
from
1d50e0f
to
e3b18f8
Compare
pbalcer
approved these changes
Aug 7, 2023
aarongreig
approved these changes
Aug 8, 2023
callumfare
approved these changes
Aug 8, 2023
This was referenced Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Adds a
is_handle_vcheck which is necessary when we have tests (i.e. the CUDA/HIP) specific ones that link against the actual implementation of an adapter and the type is complete.TODO - cherry pick this commit into the
adaptersbranch