-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXP][CMDBUF] Add adapters code for Prefetch and Advise commands #937
[EXP][CMDBUF] Add adapters code for Prefetch and Advise commands #937
Conversation
Linked DPC++ PR: intel/llvm#11474 |
5e12a0f
to
4d4d1de
Compare
Adds adapters code support for prefetch and advise memory hints for level_zero backend. Adds entry points for prefetch and advise memory hints for CUDA backend.
…er-prefetch-memadvice [EXP][CMDBUF] Add Prefetch and Advise commands to cmd buffer experimental feature
777eab2
to
5cc3f88
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #937 +/- ##
==========================================
- Coverage 15.79% 15.73% -0.06%
==========================================
Files 223 223
Lines 31351 31465 +114
Branches 3511 3556 +45
==========================================
+ Hits 4951 4952 +1
- Misses 26349 26462 +113
Partials 51 51 ☔ View full report in Codecov by Sentry. |
This PR was rebased after the main branch was merged with adapter branch. |
I have updated the target branch of this PR from the |
@jandres742 Could you review this again please, it's out of draft |
@nrspruit could you review on behalf of @oneapi-src/unified-runtime-level-zero-write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenCL LGTM
ping @oneapi-src/unified-runtime-cuda-write & @oneapi-src/unified-runtime-hip-write for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CUDA and HIP changes look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for level zero.
Note: This PR also includes changes from the main branch (commit 0d3c1fc) which add these commands to the UR specification, but are not present in the adapter branch yet.