Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXP][CMDBUF] Add adapters code for Prefetch and Advise commands #937

Merged
merged 16 commits into from
Jan 3, 2024

Conversation

mfrancepillois
Copy link
Contributor

@mfrancepillois mfrancepillois commented Oct 9, 2023

Note: This PR also includes changes from the main branch (commit 0d3c1fc) which add these commands to the UR specification, but are not present in the adapter branch yet.

  • Adds adapters code support for prefetch and advise memory hints for level_zero backend.
  • Adds entry points for prefetch and advise memory hints for CUDA backend.

@mfrancepillois
Copy link
Contributor Author

Linked DPC++ PR: intel/llvm#11474

source/adapters/level_zero/command_buffer.cpp Outdated Show resolved Hide resolved
source/adapters/level_zero/command_buffer.cpp Outdated Show resolved Hide resolved
source/adapters/level_zero/command_buffer.cpp Outdated Show resolved Hide resolved
source/adapters/level_zero/command_buffer.cpp Outdated Show resolved Hide resolved
@mfrancepillois mfrancepillois force-pushed the support-prefetch-advise-cmd-buffers branch from 5e12a0f to 4d4d1de Compare October 10, 2023 13:06
@mfrancepillois mfrancepillois force-pushed the support-prefetch-advise-cmd-buffers branch from 777eab2 to 5cc3f88 Compare December 4, 2023 14:49
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe2735a) 15.79% compared to head (01cd56d) 15.73%.
Report is 63 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
- Coverage   15.79%   15.73%   -0.06%     
==========================================
  Files         223      223              
  Lines       31351    31465     +114     
  Branches     3511     3556      +45     
==========================================
+ Hits         4951     4952       +1     
- Misses      26349    26462     +113     
  Partials       51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfrancepillois
Copy link
Contributor Author

This PR was rebased after the main branch was merged with adapter branch.
We also added the support for CUDA backend. Since Graph CUDA backend does not handle prefetch and mem-advise hints, these operations are implemented as empty nodes ("nop").

@mfrancepillois mfrancepillois marked this pull request as ready for review December 5, 2023 12:02
@mfrancepillois mfrancepillois requested review from a team as code owners December 5, 2023 12:02
@fabiomestre fabiomestre changed the base branch from adapters to main December 5, 2023 16:54
@fabiomestre
Copy link
Contributor

I have updated the target branch of this PR from the adapters branch to the main branch.
Development in UR is moving back to main. The adapters branch will soon be deleted.

@mfrancepillois mfrancepillois requested a review from a team as a code owner December 6, 2023 17:16
@EwanC
Copy link
Contributor

EwanC commented Dec 8, 2023

@jandres742 Could you review this again please, it's out of draft

@EwanC
Copy link
Contributor

EwanC commented Dec 11, 2023

@jandres742 Could you review this again please, it's out of draft

@nrspruit could you review on behalf of @oneapi-src/unified-runtime-level-zero-write

Copy link
Contributor

@martygrant martygrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenCL LGTM

@EwanC
Copy link
Contributor

EwanC commented Dec 13, 2023

ping @oneapi-src/unified-runtime-cuda-write & @oneapi-src/unified-runtime-hip-write for review

Copy link
Contributor

@GeorgeWeb GeorgeWeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA and HIP changes look good to me.

source/adapters/hip/command_buffer.cpp Show resolved Hide resolved
source/adapters/hip/command_buffer.cpp Show resolved Hide resolved
Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for level zero.

@EwanC EwanC added the ready to merge Added to PR's which are ready to merge label Dec 19, 2023
@kbenzie kbenzie merged commit 5d8173a into oneapi-src:main Jan 3, 2024
51 checks passed
kbenzie added a commit to kbenzie/llvm that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Added to PR's which are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants