Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickhouse Connection Argument Nonetype Bug #12314

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Conversation

ulixius9
Copy link
Member

@ulixius9 ulixius9 commented Jul 6, 2023

Describe your changes:

Clickhouse Connection Argument Nonetype Bug

when set the secure flag from UI and do not pass any connection arguments from UI it fails with the error that NoneType has no attribute __root__ this wasn't happening with the earlier versions because we used to pass the empty dict from the UI itself but since now UI sends null it fails with this error.

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2023

[open-metadata-airflow-apis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ulixius9 ulixius9 merged commit 91189b5 into 1.1.0 Jul 6, 2023
10 of 19 checks passed
@ulixius9 ulixius9 deleted the clickhouse_secure_fix branch July 6, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants