Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clickhouse Connection Argument Nonetype Bug #12314

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Clickhouse Connection Argument Nonetype Bug #12314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6a2085
Clickhouse fix connection argument nonetype bug
ulixius9 Jul 6, 2023
df896bb
Bump ingestion version to 1.1.0.3
ulixius9 Jul 6, 2023
ed5ec71
update dockerfile
ulixius9 Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ingestion/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ USER airflow
# Argument to provide for Ingestion Dependencies to install. Defaults to all
ARG INGESTION_DEPENDENCY="all"
RUN pip install --upgrade pip
RUN pip install "openmetadata-managed-apis==1.1.0.2" --constraint "https://raw.githubusercontent.com/apache/airflow/constraints-2.3.3/constraints-3.9.txt"
RUN pip install "openmetadata-ingestion[${INGESTION_DEPENDENCY}]==1.1.0.2"
RUN pip install "openmetadata-managed-apis==1.1.0.3" --constraint "https://raw.githubusercontent.com/apache/airflow/constraints-2.3.3/constraints-3.9.txt"
RUN pip install "openmetadata-ingestion[${INGESTION_DEPENDENCY}]==1.1.0.3"

# Temporary workaround for https://github.com/open-metadata/OpenMetadata/issues/9593
RUN echo "Image built for $(uname -m)"
Expand Down
4 changes: 2 additions & 2 deletions ingestion/operators/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ RUN pip install --upgrade pip

ARG INGESTION_DEPENDENCY="all"
RUN pip install --upgrade pip
RUN pip install "openmetadata-ingestion[airflow]~=1.1.0.2"
RUN pip install "openmetadata-ingestion[${INGESTION_DEPENDENCY}]~=1.1.0.2"
RUN pip install "openmetadata-ingestion[airflow]~=1.1.0.3"
RUN pip install "openmetadata-ingestion[${INGESTION_DEPENDENCY}]~=1.1.0.3"

# Temporary workaround for https://github.com/open-metadata/OpenMetadata/issues/9593
RUN echo "Image built for $(uname -m)"
Expand Down
2 changes: 1 addition & 1 deletion ingestion/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ def get_long_description():
build_options = {"includes": ["_cffi_backend"]}
setup(
name="openmetadata-ingestion",
version="1.1.0.2",
version="1.1.0.3",
url="https://open-metadata.org/",
author="OpenMetadata Committers",
license="Apache License 2.0",
Expand Down
2 changes: 1 addition & 1 deletion ingestion/src/metadata/ingestion/source/database/clickhouse/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def get_connection(connection: ClickhouseConnection) -> Engine:
Create Clickhouse connection
"""
if connection.secure or connection.keyfile:
if connection.connectionArguments:
if not connection.connectionArguments:
connection.connectionArguments = init_empty_connection_arguments()
if connection.secure:
connection.connectionArguments.__root__["secure"] = connection.secure
Expand Down
2 changes: 1 addition & 1 deletion openmetadata-airflow-apis/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def get_long_description():
packages=find_packages(include=[f"{PLUGIN_NAME}.*", PLUGIN_NAME]),
include_package_data=True,
package_data={PLUGIN_NAME: get_package_data()},
version="1.1.0.2",
version="1.1.0.3",
url="https://open-metadata.org/",
author="OpenMetadata Committers",
license="Apache License 2.0",
Expand Down