Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Add playwright test for entity pages with users with different roles #17316

Merged
merged 25 commits into from
Aug 13, 2024
Merged

Minor: Add playwright test for entity pages with users with different roles #17316

merged 25 commits into from
Aug 13, 2024

Conversation

aniketkatkar97
Copy link
Member

@aniketkatkar97 aniketkatkar97 commented Aug 6, 2024 •
edited
Loading

I worked on adding role-based tests of entity details pages for DataStewards and DataConsumers

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 added UI UI specific issues e2e This will trigger e2e test workflows labels Aug 6, 2024
@aniketkatkar97 aniketkatkar97 self-assigned this Aug 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 64.96% (36930/56853) 41.67% (14725/35339) 43.71% (4482/10254)

@cypress Cypress
Copy link

cypress bot commented Aug 6, 2024 •
edited
Loading


Test summary

199 • 1 • 12 • 19

Run details
Project openmetadata
Status Failed
Commit 3f0faf0
Started Aug 13, 2024 11:23 AM
Ended Aug 13, 2024 11:52 AM
Duration 29:26 💡
OS Linux Ubuntu -
Browser Multiple

View run in Cypress Cloud ➡️

Failures

cypress/e2e/Pages/Glossary.spec.ts 1 Failed
1 Glossary page should work properly > Create new glossary flow should work properly

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 13, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@aniketkatkar97 aniketkatkar97 merged commit d77aac4 into main Aug 13, 2024
15 of 17 checks passed
@aniketkatkar97 aniketkatkar97 deleted the rolebased-entity-tests branch August 13, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani chirag-madlani is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees

@aniketkatkar97 aniketkatkar97

Labels
e2e:Governance e2e:Integration e2e:Observability e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aniketkatkar97 @ShaileshParmar11