Minor: Add playwright test for entity pages with users with different roles

openmetadata-ui/src/main/resources/ui/playwright.config.ts

@@ -30,9 +30,10 @@ export default defineConfig({
  /* Fail the build on CI if you accidentally left test.only in the source code. */
  forbidOnly: !!process.env.CI,
  /* Retry on CI only */
- retries: process.env.CI ? 2 : 0,
+ retries: process.env.CI ? 1 : 0,
  /* Opt out of parallel tests on CI. */
- workers: process.env.CI ? 2 : undefined,
+ workers: process.env.CI ? 3 : undefined,
+ maxFailures: 30,
  /* Reporter to use. See https://playwright.dev/docs/test-reporters */
  reporter: [
  ['list'],

openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Entity.spec.ts

@@ -11,6 +11,7 @@
  * limitations under the License.
  */
 import { test } from '@playwright/test';
+import { isUndefined } from 'lodash';
 import { CustomPropertySupportedEntityList } from '../../constant/customProperty';
 import { ApiEndpointClass } from '../../support/entity/ApiEndpointClass';
 import { ContainerClass } from '../../support/entity/ContainerClass';
@@ -113,6 +114,42 @@ entities.forEach((EntityClass) => {
  );
  });
 
+ // Run only if entity has children
+ if (!isUndefined(entity.childrenTabId)) {
+ test('Tag Add, Update and Remove for child entities', async ({
+ page,
+ }) => {
+ await page.getByTestId(entity.childrenTabId ?? '').click();
+
+ await entity.tagChildren({
+ page: page,
+ tag1: 'PersonalData.Personal',
+ tag2: 'PII.None',
+ rowId: entity.childrenSelectorId ?? '',
+ rowSelector:
+ entity.type === 'MlModel' ? 'data-testid' : 'data-row-key',
+ });
+ });
+ }
+
+ // Run only if entity has children
+ if (!isUndefined(entity.childrenTabId)) {
+ test('Glossary Term Add, Update and Remove for child entities', async ({
+ page,
+ }) => {
+ await page.getByTestId(entity.childrenTabId ?? '').click();
+
+ await entity.glossaryTermChildren({
+ page: page,
+ glossaryTerm1: EntityDataClass.glossaryTerm1.responseData,
+ glossaryTerm2: EntityDataClass.glossaryTerm2.responseData,
+ rowId: entity.childrenSelectorId ?? '',
+ rowSelector:
+ entity.type === 'MlModel' ? 'data-testid' : 'data-row-key',
+ });
+ });
+ }
+
  test(`Announcement create & delete`, async ({ page }) => {
  await entity.announcement(
  page,
@@ -148,7 +185,7 @@ entities.forEach((EntityClass) => {
 
  await test.step(`Set ${titleText} Custom Property`, async () => {
  for (const type of properties) {
- await entity.setCustomProperty(
+ await entity.updateCustomProperty(
  page,
  entity.customPropertyValue[type].property,
  entity.customPropertyValue[type].value

openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/EntityDataConsumer.spec.ts

@@ -0,0 +1,171 @@
+/*
+ * Copyright 2024 Collate.
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import { expect, Page, test as base } from '@playwright/test';
+import { isUndefined } from 'lodash';
+import { ApiEndpointClass } from '../../support/entity/ApiEndpointClass';
+import { ContainerClass } from '../../support/entity/ContainerClass';
+import { DashboardClass } from '../../support/entity/DashboardClass';
+import { DashboardDataModelClass } from '../../support/entity/DashboardDataModelClass';
+import { EntityDataClass } from '../../support/entity/EntityDataClass';
+import { MlModelClass } from '../../support/entity/MlModelClass';
+import { PipelineClass } from '../../support/entity/PipelineClass';
+import { SearchIndexClass } from '../../support/entity/SearchIndexClass';
+import { StoredProcedureClass } from '../../support/entity/StoredProcedureClass';
+import { TableClass } from '../../support/entity/TableClass';
+import { TopicClass } from '../../support/entity/TopicClass';
+import { UserClass } from '../../support/user/UserClass';
+import { performAdminLogin } from '../../utils/admin';
+import { redirectToHomePage } from '../../utils/common';
+
+const user = new UserClass();
+
+const entities = [
+ ApiEndpointClass,
+ TableClass,
+ StoredProcedureClass,
+ DashboardClass,
+ PipelineClass,
+ TopicClass,
+ MlModelClass,
+ ContainerClass,
+ SearchIndexClass,
+ DashboardDataModelClass,
+] as const;
+
+// Create 2 page and authenticate 1 with admin and another with normal user
+const test = base.extend<{
+ page: Page;
+}>({
+ page: async ({ browser }, use) => {
+ const page = await browser.newPage();
+ await user.login(page);
+ await use(page);
+ await page.close();
+ },
+});
+
+entities.forEach((EntityClass) => {
+ const entity = new EntityClass();
+
+ test.describe(entity.getType(), () => {
+ test.beforeAll('Setup pre-requests', async ({ browser }) => {
+ const { apiContext, afterAction } = await performAdminLogin(browser);
+
+ await user.create(apiContext);
+ await EntityDataClass.preRequisitesForTests(apiContext);
+ await entity.create(apiContext);
+ await afterAction();
+ });
+
+ test.beforeEach('Visit entity details page', async ({ page }) => {
+ await redirectToHomePage(page);
+ await entity.visitEntityPage(page);
+ });
+
+ test('User as Owner Add, Update and Remove', async ({ page }) => {
+ test.slow(true);
+
+ const OWNER1 = EntityDataClass.user1.getUserName();
+ const OWNER2 = EntityDataClass.user2.getUserName();
+ const OWNER3 = EntityDataClass.user3.getUserName();
+ await entity.owner(page, [OWNER1, OWNER3], [OWNER2], undefined, false);
+ });
+
+ test('No edit owner permission', async ({ page }) => {
+ await page.reload();
+ await page.waitForSelector('[data-testid="loader"]', {
+ state: 'detached',
+ });
+
+ await expect(page.getByTestId('edit-owner')).not.toBeAttached();
+ });
+
+ test('Tier Add, Update and Remove', async ({ page }) => {
+ await entity.tier(
+ page,
+ 'Tier1',
+ EntityDataClass.tierTag1.data.displayName
+ );
+ });
+
+ test('Update description', async ({ page }) => {
+ await entity.descriptionUpdate(page);
+ });
+
+ test('Tag Add, Update and Remove', async ({ page }) => {
+ await entity.tag(page, 'PersonalData.Personal', 'PII.None');
+ });
+
+ test('Glossary Term Add, Update and Remove', async ({ page }) => {
+ await entity.glossaryTerm(
+ page,
+ EntityDataClass.glossaryTerm1.responseData,
+ EntityDataClass.glossaryTerm2.responseData
+ );
+ });
+
+ // Run only if entity has children
+ if (!isUndefined(entity.childrenTabId)) {
+ test('Tag Add, Update and Remove for child entities', async ({
+ page,
+ }) => {
+ await page.getByTestId(entity.childrenTabId ?? '').click();
+
+ await entity.tagChildren({
+ page,
+ tag1: 'PersonalData.Personal',
+ tag2: 'PII.None',
+ rowId: entity.childrenSelectorId ?? '',
+ rowSelector:
+ entity.type === 'MlModel' ? 'data-testid' : 'data-row-key',
+ });
+ });
+ }
+
+ // Run only if entity has children
+ if (!isUndefined(entity.childrenTabId)) {
+ test('Glossary Term Add, Update and Remove for child entities', async ({
+ page,
+ }) => {
+ await page.getByTestId(entity.childrenTabId ?? '').click();
+
+ await entity.glossaryTermChildren({
+ page,
+ glossaryTerm1: EntityDataClass.glossaryTerm1.responseData,
+ glossaryTerm2: EntityDataClass.glossaryTerm2.responseData,
+ rowId: entity.childrenSelectorId ?? '',
+ rowSelector:
+ entity.type === 'MlModel' ? 'data-testid' : 'data-row-key',
+ });
+ });
+ }
+
+ test(`UpVote & DownVote entity`, async ({ page }) => {
+ await entity.upVote(page);
+ await entity.downVote(page);
+ });
+
+ test(`Follow & Un-follow entity`, async ({ page }) => {
+ const entityName = entity.entityResponseData?.['displayName'];
+ await entity.followUnfollowEntity(page, entityName);
+ });
+
+ test.afterAll('Cleanup', async ({ browser }) => {
+ const { apiContext, afterAction } = await performAdminLogin(browser);
+ await user.delete(apiContext);
+ await entity.delete(apiContext);
+ await EntityDataClass.postRequisitesForTests(apiContext);
+ await afterAction();
+ });
+ });
+});