Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #17869: Add validations in place for salesforce connection #17870

Merged
merged 7 commits into from
Sep 20, 2024
Merged

Fixes #17869: Add validations in place for salesforce connection #17870

merged 7 commits into from
Sep 20, 2024

Conversation

ayush-shah
Copy link
Member

Describe your changes:

Fixes #17869

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@ayush-shah ayush-shah requested a review from a team as a code owner September 17, 2024 03:08
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Sep 17, 2024
ulixius9
ulixius9 previously approved these changes Sep 17, 2024
View reviewed changes
pmbrull
pmbrull previously approved these changes Sep 17, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 17, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ayush-shah ayush-shah marked this pull request as draft September 18, 2024 05:39
@harshsoni2024 harshsoni2024 dismissed stale reviews from pmbrull and ulixius9 via dc655b1 September 19, 2024 07:55
@harshsoni2024 harshsoni2024 marked this pull request as ready for review September 19, 2024 09:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.31% (37352/58081) 40.96% (14784/36096) 43.07% (4507/10465)

@notion-workspace Notion Workspace
Copy link

Salesforce Optional session token

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ayush-shah ayush-shah merged commit 8087f48 into main Sep 20, 2024
20 of 27 checks passed
@ayush-shah ayush-shah deleted the issue-17869 branch September 20, 2024 11:03
harshsoni2024 pushed a commit that referenced this pull request Sep 20, 2024
@ayush-shah @harshsoni2024
Fixes #17869: Add validations in place for salesforce connection (#17870
c90b7b0 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

@ulixius9 ulixius9 ulixius9 left review comments

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11 ShaileshParmar11 is a code owner

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani chirag-madlani is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvement: Salesforce validations for password and securityToken
4 participants
@ayush-shah @pmbrull @ulixius9 @harshsoni2024