Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #17869: Add validations in place for salesforce connection #17870

Merged
merged 7 commits into from
Sep 20, 2024
Merged

Fixes #17869: Add validations in place for salesforce connection #17870

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3298cdc
fix: Add validations in place
ayush-shah Sep 17, 2024
7a2b091
Merge branch 'main' into issue-17869
pmbrull Sep 17, 2024
dc655b1
add organization id in salesforce connection
harshsoni2024 Sep 19, 2024
4081c69
add org_id in docs
harshsoni2024 Sep 19, 2024
620229e
Merge branch 'main' into issue-17869
harshsoni2024 Sep 19, 2024
9299257
add detailed doc on org id
harshsoni2024 Sep 20, 2024
ae6e983
Merge branch 'main' into issue-17869
harshsoni2024 Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ingestion/src/metadata/ingestion/source/database/salesforce/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
from typing import Optional

from simple_salesforce.api import Salesforce
from sqlalchemy.engine import Engine

from metadata.generated.schema.entity.automations.workflow import (
Workflow as AutomationWorkflow,
Expand All @@ -27,14 +26,18 @@
from metadata.ingestion.ometa.ometa_api import OpenMetadata


def get_connection(connection: SalesforceConnection) -> Engine:
def get_connection(connection: SalesforceConnection):
"""
Create connection
"""
return Salesforce(
username=connection.username,
password=connection.password.get_secret_value(),
security_token=connection.securityToken.get_secret_value(),
password=connection.password.get_secret_value()
if connection.password
else None,
security_token=connection.securityToken.get_secret_value()
if connection.securityToken
else None,
domain=connection.salesforceDomain,
version=connection.salesforceApiVersion,
**connection.connectionArguments.root if connection.connectionArguments else {},
Expand Down
Loading