-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Prepare Release 1.5.0 #254
Conversation
@@ -254,7 +262,7 @@ openmetadata: | |||
secretKey: "" | |||
secretsManager: | |||
enabled: true | |||
# Possible values are db, aws, aws-ssm, managed-aws, managed-aws-ssm, in-memory, managed-azure-kv, azure-kv | |||
# Possible values are db, aws, aws-ssm, managed-aws, managed-aws-ssm, in-memory, managed-azure-kv, azure-kv, gcp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are the list of values informed anywhere else to provide what is really supported or not? Can I use a helm value as potato
and it will eat it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use potato
in every string field, we are not doing enum validations. A nice to have feature though :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we skip the limits
and templates
settings for now?
Since |
Co-authored-by: Matias Puerta <matias@getcollate.io>
Based on the git diff below, modified:
maxSize
,minSize
,initialSize
,checkConnectionWhileIdle
,checkConnectionOnBorrow
,evictionInterval
,minIdleTime
todatabase
configurationelasticsearch
batchSize` default value to 100secretsManagerConfiguration
commentprojectId
configuration onsecretsManagerConfiguration
templates
onsmtp
configurationcacheControl
andpragma
attributes toweb
configurationTODO:
bindHost
changes