Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prepare Release 1.5.0 #254

Merged
merged 5 commits into from
Aug 26, 2024
Merged

feat: Prepare Release 1.5.0 #254

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
07804bb
Prepare Release 1.5.0
IceS2 Aug 26, 2024
a319277
Fix typo
IceS2 Aug 26, 2024
58a3310
Fix typo
IceS2 Aug 26, 2024
bb408f4
avoid adding templates as an attribute ot the chart
IceS2 Aug 26, 2024
75ba953
Update charts/openmetadata/templates/_helpers.tpl
IceS2 Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/deps/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ type: application
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)

version: 1.4.8
version: 1.5.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "1.4.8"
appVersion: "1.5.0"

home: https://open-metadata.org/

Expand Down
2 changes: 1 addition & 1 deletion charts/deps/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ airflow:
airflow:
image:
repository: docker.getcollate.io/openmetadata/ingestion
tag: 1.4.8
tag: 1.5.0
pullPolicy: "IfNotPresent"
executor: "KubernetesExecutor"
config:
Expand Down
4 changes: 2 additions & 2 deletions charts/openmetadata/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ type: application
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)

version: 1.4.8
version: 1.5.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "1.4.8"
appVersion: "1.5.0"

home: https://open-metadata.org/

Expand Down
2 changes: 1 addition & 1 deletion charts/openmetadata/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ helm install openmetadata open-metadata/openmetadata --values <<path-to-values-f
| fullnameOverride | string | `"openmetadata"` |
| image.pullPolicy | string | `"Always"` |
| image.repository | string | `"docker.getcollate.io/openmetadata/server"` |
| image.tag | string | `1.4.8` |
| image.tag | string | `1.5.0` |
| imagePullSecrets | list | `[]` |
| ingress.annotations | object | `{}` |
| ingress.className | string | `""` |
Expand Down
16 changes: 16 additions & 0 deletions charts/openmetadata/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,22 @@ OpenMetadata Configurations Azure Additional Parameters Environment Variables fo
{{- end }}
{{- end -}}


{{/*
OpenMetadata Configurations GCP Additional Parameters Environment Variables for Secret Manager
*/}}
{{- define "OpenMetadata.configs.secretManager.gcp.additionalParameters" -}}
{{- with .Values.openmetadata.config.secretsManager.additionalParameters.projectId }}
{{- if .secretRef }}
- name: OM_SM_POROJECT_ID
IceS2 marked this conversation as resolved.
Show resolved Hide resolved
valueFrom:
secretKeyRef:
name: {{ .secretRef }}
key: {{ .secretKey }}
{{- end }}
{{- end }}
{{- end -}}

{{/*
OpenMetadata Configurations Environment Variables*/}}
{{- define "OpenMetadata.configs" -}}
Expand Down
9 changes: 9 additions & 0 deletions charts/openmetadata/templates/secrets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ data:
OM_DATABASE: {{ .databaseName | b64enc }}
DB_PARAMS: {{ .dbParams | b64enc | quote }}
DB_USER: {{ .auth.username | b64enc }}
DB_CONNECTION_POOL_MAX_SIZE: {{ .maxSize | quote | b64enc }}
DB_CONNECTION_POOL_MIN_SIZE: {{ .minSize | quote | b64enc }}
DB_CONNECTION_POOL_INITIAL_SIZE: {{ .initialSize | quote | b64enc }}
DB_CONNECTION_CHECK_CONNECTION_WHILE_IDLE: {{ .checkConnectionWhileIdle | quote | b64enc }}
DB_CONNECTION_CHECK_CONNECTION_ON_BORROW: {{ .checkCOnnectionOnBorrow | quote | b64enc }}
DB_CONNECTION_EVICTION_INTERVAL: {{ .evictionInterval | quote | b64enc }}
DB_CONNECTION_MIN_IDLE_TIME: {{ .minIdleTime | quote | b64enc }}
{{ end }}
{{ end }}

Expand Down Expand Up @@ -201,6 +208,8 @@ data:
WEB_CONF_REFERRER_POLICY_OPTION: {{ .referrerPolicy.option | quote | b64enc }}
WEB_CONF_PERMISSION_POLICY_ENABLED: {{ .permissionPolicy.enabled | quote | b64enc }}
WEB_CONF_PERMISSION_POLICY_OPTION: {{ .permissionPolicy.option | quote | b64enc }}
WEB_CONF_CACHE_CONTROL: {{ .cacheControl | quote | b64enc }}
WEB_CONF_PRAGMA: {{ .pragma | quote | b64enc }}
{{ end }}
{{ end }}

Expand Down
39 changes: 39 additions & 0 deletions charts/openmetadata/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,12 @@
}
}
},
"cacheControl": {
"type": "string"
},
"pragma": {
"type": "string"
},
"xssProtection": {
"type": "object",
"additionalProperties": false,
Expand Down Expand Up @@ -747,6 +753,27 @@
},
"port": {
"type": "integer"
},
"maxSize": {
"type": "integer"
},
"minSize": {
"type": "integer"
},
"initialSize": {
"type": "integer"
},
"checkConnectionWhileIdle": {
"type": "boolean"
},
"checkConnectionOnBorrow": {
"type": "boolean"
},
"evictionInterval": {
"type": "string"
},
"minIdleTime": {
"type": "string"
}
}
},
Expand Down Expand Up @@ -1013,6 +1040,18 @@
"type": "string"
}
}
},
"projectId": {
"type": "object",
"additionalProperties": false,
"properties": {
"secretKey": {
"type": "string"
},
"secretRef": {
"type": "string"
}
}
}
}
},
Expand Down
20 changes: 18 additions & 2 deletions charts/openmetadata/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ openmetadata:
payLoadSize: 10485760
connectionTimeoutSecs: 5
socketTimeoutSecs: 60
batchSize: 10
batchSize: 100
searchIndexMappingLanguage: "EN"
keepAliveTimeoutSecs: 600
trustStore:
Expand Down Expand Up @@ -60,6 +60,13 @@ openmetadata:
secretRef: mysql-secrets
secretKey: openmetadata-mysql-password
dbParams: "allowPublicKeyRetrieval=true&useSSL=false&serverTimezone=UTC"
maxSize: 50
minSize: 10
initialSize: 10
checkConnectionWhileIdle: true
checkConnectionOnBorrow: true
evictionInterval: 5 minutes
minIdleTime: 1 minute
pipelineServiceClientConfig:
enabled: true
className: "org.openmetadata.service.clients.pipeline.airflow.AirflowRESTClient"
Expand Down Expand Up @@ -254,7 +261,7 @@ openmetadata:
secretKey: ""
secretsManager:
enabled: true
# Possible values are db, aws, aws-ssm, managed-aws, managed-aws-ssm, in-memory, managed-azure-kv, azure-kv
# Possible values are db, aws, aws-ssm, managed-aws, managed-aws-ssm, in-memory, managed-azure-kv, azure-kv, gcp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the list of values informed anywhere else to provide what is really supported or not? Can I use a helm value as potato and it will eat it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use potato in every string field, we are not doing enum validations. A nice to have feature though :)

provider: db
# Define the secret key ID as /<prefix>/<clusterName>/<key> for AWS
# Define the secret key ID as <prefix>-<clusterName>-<key> for Azure
Expand Down Expand Up @@ -302,6 +309,13 @@ openmetadata:
# vaultName:
# secretRef: azure-vault-name-secret
# secretKey: azure-key-secret
# For GCP
projectId:
secretRef: ""
secretKey: ""
# projectId:
# secretRef: gcp-project-id-secret
# secretKey: gcp-key-secret
# You can create Kubernetes secrets from AWS Credentials with the below command
# kubectl create secret generic aws-key-secret \
# --from-literal=aws-access-key-secret=<access_key_id_value> \
Expand Down Expand Up @@ -334,6 +348,8 @@ openmetadata:
permissionPolicy:
enabled: false
option: ""
cacheControl: ""
pragma: ""

networkPolicy:
# If networkPolicy is true, following values can be set
Expand Down
Loading