Change various usages of minimum to exclusiveMinimum #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
commented
Dec 9, 2024
| @@ -27,16 +27,16 @@ logger_provider: | |||
| processors: | |||
| - # Configure a batch log record processor. | |||
| batch: | |||
| # Configure delay interval (in milliseconds) between two consecutive exports. | |||
| # Configure delay interval (in milliseconds) between two consecutive exports. Value must be > 0. | |||
| # If omitted or null, 1000 is used. | |||
| schedule_delay: 5000 | |||
There was a problem hiding this comment.
Arguably a schedule delay of 0 is valid. Made this change anyway to prompt debate.
There was a problem hiding this comment.
I agree with your comment about 0 being valid open-telemetry/opentelemetry-specification#4331 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to open-telemetry/opentelemetry-specification#4283, but not blocked by the resolution over there.
With #142, the main principle of what constitutes an allowed change is whether it makes validation more or less restrictive. In reviewing our use of the JSON schema minimum keyword, which has inclusive semantics, I found a variety of areas which may come back to bite us. In all these cases, the minimum is currently set to 0. But if the user sets the property value to zero, the semantics are unclear.
Best to prohibit zero in these cases, since we can later loosen the restriction to allow zero but won't be able to make it more strict.
Cases: