Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change various usages of minimum to exclusiveMinimum #151

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change various usages of minimum to exclusiveMinimum #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions examples/kitchen-sink.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,16 @@ logger_provider:
processors:
- # Configure a batch log record processor.
batch:
# Configure delay interval (in milliseconds) between two consecutive exports.
# Configure delay interval (in milliseconds) between two consecutive exports. Value must be > 0.
# If omitted or null, 1000 is used.
schedule_delay: 5000
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguably a schedule delay of 0 is valid. Made this change anyway to prompt debate.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your comment about 0 being valid open-telemetry/opentelemetry-specification#4331 (comment)

# Configure maximum allowed time (in milliseconds) to export data.
# Configure maximum allowed time (in milliseconds) to export data. Value must be > 0.
# If omitted or null, 30000 is used.
export_timeout: 30000
# Configure maximum queue size.
# Configure maximum queue size. Value must be > 0.
# If omitted or null, 2048 is used.
max_queue_size: 2048
# Configure maximum batch size.
# Configure maximum batch size. Value must be > 0.
# If omitted or null, 512 is used.
max_export_batch_size: 512
# Configure exporter.
Expand Down Expand Up @@ -69,7 +69,7 @@ logger_provider:
# Configure compression. Values include: gzip, none. Implementations may support other compression algorithms.
# If omitted or null, none is used.
compression: gzip
# Configure max time (in milliseconds) to wait for each export.
# Configure max time (in milliseconds) to wait for each export. Value must be > 0.
# If omitted or null, 10000 is used.
timeout: 10000
# Configure client transport security for the exporter's connection. Only applicable when .protocol is grpc and .endpoint is provided without http or https scheme. Implementations may choose to ignore .insecure.
Expand Down Expand Up @@ -136,10 +136,10 @@ meter_provider:
- opencensus:
- # Configure a periodic metric reader.
periodic:
# Configure delay interval (in milliseconds) between start of two consecutive exports.
# Configure delay interval (in milliseconds) between start of two consecutive exports. Value must be > 0.
# If omitted or null, 60000 is used.
interval: 60000
# Configure maximum allowed time (in milliseconds) to export data.
# Configure maximum allowed time (in milliseconds) to export data. Value must be > 0.
# If omitted or null, 30000 is used.
timeout: 30000
# Configure exporter.
Expand Down Expand Up @@ -172,7 +172,7 @@ meter_provider:
# Configure compression. Values include: gzip, none. Implementations may support other compression algorithms.
# If omitted or null, none is used.
compression: gzip
# Configure max time (in milliseconds) to wait for each export.
# Configure max time (in milliseconds) to wait for each export. Value must be > 0.
# If omitted or null, 10000 is used.
timeout: 10000
# Configure client transport security for the exporter's connection. Only applicable when .protocol is grpc and .endpoint is provided without http or https scheme. Implementations may choose to ignore .insecure.
Expand Down Expand Up @@ -277,16 +277,16 @@ tracer_provider:
processors:
- # Configure a batch span processor.
batch:
# Configure delay interval (in milliseconds) between two consecutive exports.
# Configure delay interval (in milliseconds) between two consecutive exports. Value must be > 0.
# If omitted or null, 5000 is used.
schedule_delay: 5000
# Configure maximum allowed time (in milliseconds) to export data.
# Configure maximum allowed time (in milliseconds) to export data. Value must be > 0.
# If omitted or null, 30000 is used.
export_timeout: 30000
# Configure maximum queue size.
# Configure maximum queue size. Value must be > 0.
# If omitted or null, 2048 is used.
max_queue_size: 2048
# Configure maximum batch size.
# Configure maximum batch size. Value must be > 0.
# If omitted or null, 512 is used.
max_export_batch_size: 512
# Configure exporter.
Expand Down Expand Up @@ -319,7 +319,7 @@ tracer_provider:
# Configure compression. Values include: gzip, none. Implementations may support other compression algorithms.
# If omitted or null, none is used.
compression: gzip
# Configure max time (in milliseconds) to wait for each export.
# Configure max time (in milliseconds) to wait for each export. Value must be > 0.
# If omitted or null, 10000 is used.
timeout: 10000
# Configure client transport security for the exporter's connection. Only applicable when .protocol is grpc and .endpoint is provided without http or https scheme. Implementations may choose to ignore .insecure.
Expand All @@ -334,7 +334,7 @@ tracer_provider:
# Configure endpoint.
# If omitted or null, http://localhost:9411/api/v2/spans is used.
endpoint: http://localhost:9411/api/v2/spans
# Configure max time (in milliseconds) to wait for each export.
# Configure max time (in milliseconds) to wait for each export. Value must be > 0.
# If omitted or null, 10000 is used.
timeout: 10000
- # Configure a simple span processor.
Expand Down
26 changes: 13 additions & 13 deletions examples/sdk-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,16 @@ tracer_provider:
processors:
- # Configure a batch span processor.
batch:
# Configure delay interval (in milliseconds) between two consecutive exports.
# Configure delay interval (in milliseconds) between two consecutive exports. Value must be > 0.
# If omitted or null, 5000 is used.
schedule_delay: 5000
# Configure maximum allowed time (in milliseconds) to export data.
# Configure maximum allowed time (in milliseconds) to export data. Value must be > 0.
# If omitted or null, 30000 is used.
export_timeout: 30000
# Configure maximum queue size.
# Configure maximum queue size. Value must be > 0.
# If omitted or null, 2048 is used.
max_queue_size: 2048
# Configure maximum batch size.
# Configure maximum batch size. Value must be > 0.
# If omitted or null, 512 is used.
max_export_batch_size: 512
# Configure exporter.
Expand All @@ -74,7 +74,7 @@ tracer_provider:
# Configure compression. Values include: gzip, none. Implementations may support other compression algorithms.
# If omitted or null, none is used.
compression: gzip
# Configure max time (in milliseconds) to wait for each export.
# Configure max time (in milliseconds) to wait for each export. Value must be > 0.
# If omitted or null, 10000 is used.
timeout: 10000
# Configure headers. Entries have higher priority than entries from .headers_list.
Expand Down Expand Up @@ -137,10 +137,10 @@ meter_provider:
readers:
- # Configure a periodic metric reader.
periodic:
# Configure delay interval (in milliseconds) between start of two consecutive exports.
# Configure delay interval (in milliseconds) between start of two consecutive exports. Value must be > 0.
# If omitted or null, 60000 is used.
interval: 60000
# Configure maximum allowed time (in milliseconds) to export data.
# Configure maximum allowed time (in milliseconds) to export data. Value must be > 0.
# If omitted or null, 30000 is used.
timeout: 30000
# Configure exporter.
Expand All @@ -164,7 +164,7 @@ meter_provider:
# Configure compression. Values include: gzip, none. Implementations may support other compression algorithms.
# If omitted or null, none is used.
compression: gzip
# Configure max time (in milliseconds) to wait for each export.
# Configure max time (in milliseconds) to wait for each export. Value must be > 0.
# If omitted or null, 10000 is used.
timeout: 10000
# Configure headers. Entries have higher priority than entries from .headers_list.
Expand All @@ -186,16 +186,16 @@ logger_provider:
processors:
- # Configure a batch log record processor.
batch:
# Configure delay interval (in milliseconds) between two consecutive exports.
# Configure delay interval (in milliseconds) between two consecutive exports. Value must be > 0.
# If omitted or null, 1000 is used.
schedule_delay: 1000
# Configure maximum allowed time (in milliseconds) to export data.
# Configure maximum allowed time (in milliseconds) to export data. Value must be > 0.
# If omitted or null, 30000 is used.
export_timeout: 30000
# Configure maximum queue size.
# Configure maximum queue size. Value must be > 0.
# If omitted or null, 2048 is used.
max_queue_size: 2048
# Configure maximum batch size.
# Configure maximum batch size. Value must be > 0.
# If omitted or null, 512 is used.
max_export_batch_size: 512
# Configure exporter.
Expand All @@ -219,7 +219,7 @@ logger_provider:
# Configure compression. Values include: gzip, none. Implementations may support other compression algorithms.
# If omitted or null, none is used.
compression: gzip
# Configure max time (in milliseconds) to wait for each export.
# Configure max time (in milliseconds) to wait for each export. Value must be > 0.
# If omitted or null, 10000 is used.
timeout: 10000
# Configure headers. Entries have higher priority than entries from .headers_list.
Expand Down
26 changes: 13 additions & 13 deletions examples/sdk-migration-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,16 +74,16 @@ tracer_provider:
processors:
- # Configure a batch span processor.
batch:
# Configure delay interval (in milliseconds) between two consecutive exports.
# Configure delay interval (in milliseconds) between two consecutive exports. Value must be > 0.
# If omitted or null, 5000 is used.
schedule_delay: ${OTEL_BSP_SCHEDULE_DELAY:-5000}
# Configure maximum allowed time (in milliseconds) to export data.
# Configure maximum allowed time (in milliseconds) to export data. Value must be > 0.
# If omitted or null, 30000 is used.
export_timeout: ${OTEL_BSP_EXPORT_TIMEOUT:-30000}
# Configure maximum queue size.
# Configure maximum queue size. Value must be > 0.
# If omitted or null, 2048 is used.
max_queue_size: ${OTEL_BSP_MAX_QUEUE_SIZE:-2048}
# Configure maximum batch size.
# Configure maximum batch size. Value must be > 0.
# If omitted or null, 512 is used.
max_export_batch_size: ${OTEL_BSP_MAX_EXPORT_BATCH_SIZE:-512}
# Configure exporter.
Expand All @@ -107,7 +107,7 @@ tracer_provider:
# Configure compression. Values include: gzip, none. Implementations may support other compression algorithms.
# If omitted or null, none is used.
compression: ${OTEL_EXPORTER_OTLP_TRACES_COMPRESSION:-gzip}
# Configure max time (in milliseconds) to wait for each export.
# Configure max time (in milliseconds) to wait for each export. Value must be > 0.
# If omitted or null, 10000 is used.
timeout: ${OTEL_EXPORTER_OTLP_TRACES_TIMEOUT:-10000}
# Configure headers. Entries have higher priority than entries from .headers_list.
Expand Down Expand Up @@ -176,10 +176,10 @@ meter_provider:
readers:
- # Configure a periodic metric reader.
periodic:
# Configure delay interval (in milliseconds) between start of two consecutive exports.
# Configure delay interval (in milliseconds) between start of two consecutive exports. Value must be > 0.
# If omitted or null, 60000 is used.
interval: ${OTEL_METRIC_EXPORT_INTERVAL:-60000}
# Configure maximum allowed time (in milliseconds) to export data.
# Configure maximum allowed time (in milliseconds) to export data. Value must be > 0.
# If omitted or null, 30000 is used.
timeout: ${OTEL_METRIC_EXPORT_TIMEOUT:-30000}
# Configure exporter.
Expand All @@ -203,7 +203,7 @@ meter_provider:
# Configure compression. Values include: gzip, none. Implementations may support other compression algorithms.
# If omitted or null, none is used.
compression: ${OTEL_EXPORTER_OTLP_METRICS_COMPRESSION:-gzip}
# Configure max time (in milliseconds) to wait for each export.
# Configure max time (in milliseconds) to wait for each export. Value must be > 0.
# If omitted or null, 10000 is used.
timeout: ${OTEL_EXPORTER_OTLP_METRICS_TIMEOUT:-10000}
# Configure headers. Entries have higher priority than entries from .headers_list.
Expand All @@ -229,16 +229,16 @@ logger_provider:
processors:
- # Configure a batch log record processor.
batch:
# Configure delay interval (in milliseconds) between two consecutive exports.
# Configure delay interval (in milliseconds) between two consecutive exports. Value must be > 0.
# If omitted or null, 1000 is used.
schedule_delay: ${OTEL_BLRP_SCHEDULE_DELAY:-1000}
# Configure maximum allowed time (in milliseconds) to export data.
# Configure maximum allowed time (in milliseconds) to export data. Value must be > 0.
# If omitted or null, 30000 is used.
export_timeout: ${OTEL_BLRP_EXPORT_TIMEOUT:-30000}
# Configure maximum queue size.
# Configure maximum queue size. Value must be > 0.
# If omitted or null, 2048 is used.
max_queue_size: ${OTEL_BLRP_MAX_QUEUE_SIZE:-2048}
# Configure maximum batch size.
# Configure maximum batch size. Value must be > 0.
# If omitted or null, 512 is used.
max_export_batch_size: ${OTEL_BLRP_MAX_EXPORT_BATCH_SIZE:-512}
# Configure exporter.
Expand All @@ -262,7 +262,7 @@ logger_provider:
# Configure compression. Values include: gzip, none. Implementations may support other compression algorithms.
# If omitted or null, none is used.
compression: ${OTEL_EXPORTER_OTLP_LOGS_COMPRESSION:-gzip}
# Configure max time (in milliseconds) to wait for each export.
# Configure max time (in milliseconds) to wait for each export. Value must be > 0.
# If omitted or null, 10000 is used.
timeout: ${OTEL_EXPORTER_OTLP_LOGS_TIMEOUT:-10000}
# Configure headers. Entries have higher priority than entries from .headers_list.
Expand Down
2 changes: 1 addition & 1 deletion schema/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
},
"timeout": {
"type": ["integer", "null"],
"minimum": 0
"exclusiveMinimum": 0
},
"insecure": {
"type": ["boolean", "null"]
Expand Down
8 changes: 4 additions & 4 deletions schema/logger_provider.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,19 +37,19 @@
"properties": {
"schedule_delay": {
"type": ["integer", "null"],
"minimum": 0
"exclusiveMinimum": 0
},
"export_timeout": {
"type": ["integer", "null"],
"minimum": 0
"exclusiveMinimum": 0
},
"max_queue_size": {
"type": ["integer", "null"],
"minimum": 0
"exclusiveMinimum": 0
},
"max_export_batch_size": {
"type": ["integer", "null"],
"minimum": 0
"exclusiveMinimum": 0
},
"exporter": {
"$ref": "#/$defs/LogRecordExporter"
Expand Down
6 changes: 3 additions & 3 deletions schema/meter_provider.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@
"properties": {
"interval": {
"type": ["integer", "null"],
"minimum": 0
"exclusiveMinimum": 0
},
"timeout": {
"type": ["integer", "null"],
"minimum": 0
"exclusiveMinimum": 0
},
"exporter": {
"$ref": "#/$defs/PushMetricExporter"
Expand Down Expand Up @@ -200,7 +200,7 @@
},
"timeout": {
"type": ["integer", "null"],
"minimum": 0
"exclusiveMinimum": 0
},
"temporality_preference": {
"type": ["string", "null"],
Expand Down
12 changes: 6 additions & 6 deletions schema/tracer_provider.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,19 +29,19 @@
"properties": {
"schedule_delay": {
"type": ["integer", "null"],
"minimum": 0
"exclusiveMinimum": 0
},
"export_timeout": {
"type": ["integer", "null"],
"minimum": 0
"exclusiveMinimum": 0
},
"max_queue_size": {
"type": ["integer", "null"],
"minimum": 0
"exclusiveMinimum": 0
},
"max_export_batch_size": {
"type": ["integer", "null"],
"minimum": 0
"exclusiveMinimum": 0
},
"exporter": {
"$ref": "#/$defs/SpanExporter"
Expand Down Expand Up @@ -74,7 +74,7 @@
},
"interval": {
"type": ["integer", "null"],
"minimum": 0
"exclusiveMinimum": 0
},
"initial_sampler": {
"$ref": "#/$defs/Sampler"
Expand Down Expand Up @@ -211,7 +211,7 @@
},
"timeout": {
"type": ["integer", "null"],
"minimum": 0
"exclusiveMinimum": 0
}
},
"title": "Zipkin"
Expand Down
Loading
Loading