Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add aws Lambda instrumentation #721
feat: add aws Lambda instrumentation #721
Changes from all commits
a5a5386
42dba8e
845cc06
c708d0a
0b5891a
9601fd1
34db557
3e54dfa
fbc942e
157f219
432670a
25f0495
3252264
0a19da1
609a419
d7627e8
118f6ee
4e71325
b1536ac
72c7e9e
313e33e
625efa3
ea195c6
9807308
198d464
f01e9fe
d7c47b3
4fe7b87
ba86dc7
3cb6dd6
f412fd5
e8ed3aa
f80067b
63bf9ad
52d9bda
4381f30
8f187c9
b2fab00
8608e43
834622f
9e86457
3896d9b
26300b3
078618f
78a7040
ebcf312
5c873c9
3ae6620
dcdbc65
d6eaea7
7da938f
6279914
45a42bc
88b38c8
80ee871
0aec40e
75e0ce5
237465a
40c6316
4ebb79c
f70a66f
79d00bb
26801c0
ecc8b54
1b4d969
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not familiar with AWS Lambda. Where does the
otel_wrapper
function get called?Do you have to do this yourself everytime in the lambda script?
Would it make sense to add a creation method or command method or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otel_wrapper is a custom script that is provided by user (mostly included in layer itself, see this example from python). And in aws lambda configuration, user can specify the location of wrapper through AWS_LAMBDA_EXEC_WRAPPER.
The call sequence will be: wrapper -> opentelemetry-instrumentation-aws-lambda's handler -> user's lambda function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it should be setup in wrapper script, which will be loaded in runtime from created layer.
It kind need initialize first to resolve the original function, and rest of other language seems use this convention.