-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add aws Lambda instrumentation #721
feat: add aws Lambda instrumentation #721
Conversation
instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda/handler.rb
Outdated
Show resolved
Hide resolved
instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda/handler.rb
Outdated
Show resolved
Hide resolved
instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda/handler.rb
Outdated
Show resolved
Hide resolved
instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda.rb
Outdated
Show resolved
Hide resolved
instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda/handler.rb
Outdated
Show resolved
Hide resolved
instrumentation/aws_lambda/opentelemetry-instrumentation-aws_lambda.gemspec
Show resolved
Hide resolved
@xuan-cao-swi - Are there any tests I should run using both your opentelemetry-lambda PR and this one? |
…y-ruby-contrib into lambda-instrumentation
Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
…ws_lambda/handler.rb Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
…ws_lambda/handler.rb Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
…ws_lambda/handler.rb Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
…ws_lambda.rb Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
…telemetry-ruby-contrib into lambda-instrumentation
I will create a detailed step to test lambda-related instrumentation. |
@kaylareopelle I have created a gist for the steps; but let me know if it's uncleared or failed. |
@xuan-cao-swi, thank you for the gist. It's very helpful! I've done a bit of testing, but wasn't able to successfully get the lambda to appear in New Relic. That might be an issue on our end. I'll also try to run some tests with an open-source endpoint. I plan to resume testing when I return to work on January 2, 2024. |
…telemetry-ruby-contrib into lambda-instrumentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! I have a few, small documentation changes.
instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda/handler.rb
Outdated
Show resolved
Hide resolved
instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda/handler.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
…ws_lambda/handler.rb Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
…ws_lambda/handler.rb Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Xuan, Amazing job with this. Thank you for your hard work! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @xuan-cao-swi (and @kaylareopelle + @arielvalentin for the continued guidance!). Really looking forward to when we can get the metrics component into upstream for the full Lambda tracing experience.
@xuan-cao-swi While reviewing #887, I noticed you made a few changes to |
Yes, that would be great if can release together. I have updated the release files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was deleted on main. Please remove it from this branch.
…telemetry-ruby-contrib into lambda-instrumentation
It looks like we're getting close, @xuan-cao-swi! Is there anything else you were hoping to accomplish before we sync with main and merge this in? |
Hi @kaylareopelle , no, I think it should be ok. I will open new PR if anything come up (esp. when incorporating with lambda layer build on lambda repo) |
This instrumentation allow user to use the handler to extract parent context from header that produce distributed tracing.
Inspired by splunk ruby lambda layer and opentelemetry python lambda layer.
Ruby layer creation can be found in opentelemetry-lambda PR
Sample wrapper should be added in layer creation (with lambda instrumentation).
To test with aws lambda, you can try to follow the steps here