chore: add appraisal for Sinatra 4. #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbjans
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle and
xuan-cao-swi
as code owners
scbjans
commented
Jan 20, 2024
| end | ||
|
|
||
| appraise 'sinatra-3.x' do | ||
| gem 'sinatra', '~> 3.0' |
There was a problem hiding this comment.
was there any reason this was stricter before?
There was a problem hiding this comment.
No real reason. We don't have a consistent pattern or way to maintain the appraisals.
| @@ -35,7 +35,7 @@ Gem::Specification.new do |spec| | |||
| spec.add_development_dependency 'minitest', '~> 5.0' | |||
| spec.add_development_dependency 'opentelemetry-sdk', '~> 1.1' | |||
| spec.add_development_dependency 'opentelemetry-test-helpers', '~> 0.3' | |||
| spec.add_development_dependency 'rack-test', '~> 1.1.0' | |||
| spec.add_development_dependency 'rack-test', '~> 2.1.0' | |||
There was a problem hiding this comment.
Might as well relax this allow latest minor versions.
arielvalentin
approved these changes
Jan 22, 2024
plantfansam
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Appraisal for Sinatra 4