Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add appraisal for Sinatra 4. #827

Merged
merged 2 commits into from
Jan 22, 2024
Merged

chore: add appraisal for Sinatra 4. #827

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad49ba5
chore: add appraisal for Sinatra 4.
scbjans Jan 20, 2024
2505f4b
chore: allow for latest minor version of rack-test.
scbjans Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions instrumentation/sinatra/Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,12 @@
#
# SPDX-License-Identifier: Apache-2.0

appraise 'sinatra-3.0.x' do
gem 'sinatra', '~> 3.0.0'
appraise 'sinatra-4.x' do
gem 'sinatra', '~> 4.0'
end

appraise 'sinatra-3.x' do
gem 'sinatra', '~> 3.0'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was there any reason this was stricter before?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real reason. We don't have a consistent pattern or way to maintain the appraisals.

end

appraise 'sinatra-2.x' do
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/sinatra/opentelemetry-instrumentation-sinatra.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'minitest', '~> 5.0'
spec.add_development_dependency 'opentelemetry-sdk', '~> 1.1'
spec.add_development_dependency 'opentelemetry-test-helpers', '~> 0.3'
spec.add_development_dependency 'rack-test', '~> 1.1.0'
spec.add_development_dependency 'rack-test', '~> 2.1.0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well relax this allow latest minor versions.

spec.add_development_dependency 'rubocop', '~> 1.60.0'
spec.add_development_dependency 'rubocop-performance', '~> 1.20'
spec.add_development_dependency 'simplecov', '~> 0.17.1'
Expand Down
Loading