fix: check None before returning config #296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While replacing
python-memcache
withpymemcache
ticket link we got the following errorThe reason of above mentioned error was:
django-config-models
was returningNone
.Which was then used by
edx-platform
which tries to retrieve values fromNone
https://github.com/openedx/edx-platform/blob/master/lms/djangoapps/branding/models.py#L54
This causes errors. In this PR, we're making sure that
ConfigurationModel.current
doesn't not returnNone
.