fix: more stores #1279
fix: more stores #1279
Conversation
data/ocr/store_regex.txt
Outdated
| @@ -42,6 +51,7 @@ Carrefour | |||
| Carrefour||grand jury | |||
| Casino | |||
| Colruyt | |||
| Conad | |||
There was a problem hiding this comment.
Conad is already there (hence the failing test)
data/ocr/store_regex.txt
Outdated
| @@ -10,6 +10,15 @@ Aldi||gold[aä]hren | |||
| Aldi||gutbio | |||
| Aldi||milsani | |||
| Aldi||sprengel | |||
| Aldi||liveGfree | |||
| Aldi||Simply Nature | |||
| Aldi||Specially Selected | |||
There was a problem hiding this comment.
Specially selected may be detected on many products
data/ocr/store_regex.txt
Outdated
| Aldi||liveGfree | ||
| Aldi||Simply Nature | ||
| Aldi||Specially Selected | ||
| Aldi||Little Journey |
There was a problem hiding this comment.
Same thing for little journey or friendly farms
There was a problem hiding this comment.
those combinations of words are unlikely to happen ? I'm removing simply nature
There was a problem hiding this comment.
Well technically they can. The thing is, it is autoapplied here. We should either check that it doesn't occur in the dataset, or have a way to have validation from a human.
Codecov Report
@@ Coverage Diff @@
## main #1279 +/- ##
==========================================
- Coverage 56.49% 56.44% -0.05%
==========================================
Files 77 77
Lines 7496 7520 +24
==========================================
+ Hits 4235 4245 +10
- Misses 3261 3275 +14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
What