Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more stores #1279

Merged
merged 5 commits into from
Oct 30, 2023
Merged

fix: more stores #1279

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fd97761
fix: more stores
teolemon Oct 26, 2023
3cab5cb
Update store_regex.txt
teolemon Oct 27, 2023
e40e831
Update store_regex.txt
teolemon Oct 27, 2023
2446490
Update data/ocr/store_regex.txt
teolemon Oct 27, 2023
0a04506
Apply suggestions from code review
teolemon Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions data/ocr/store_regex.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,15 @@ Aldi||gold[aä]hren
Aldi||gutbio
Aldi||milsani
Aldi||sprengel
Aldi||liveGfree
Aldi||Simply Nature
teolemon marked this conversation as resolved.
Show resolved Hide resolved
Aldi||Specially Selected
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specially selected may be detected on many products

Aldi||Little Journey
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing for little journey or friendly farms

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those combinations of words are unlikely to happen ? I'm removing simply nature

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well technically they can. The thing is, it is autoapplied here. We should either check that it doesn't occur in the dataset, or have a way to have validation from a human.

teolemon marked this conversation as resolved.
Show resolved Hide resolved
Aldi||Winking Owl
Aldi||Ambiano
Aldi||Barissimo
Aldi||Friendly Farms
teolemon marked this conversation as resolved.
Show resolved Hide resolved
Aldi||Millville
Alimerka
Alnatura
Alteza
Expand Down Expand Up @@ -42,6 +51,7 @@ Carrefour
Carrefour||grand jury
Casino
Colruyt
Conad
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conad is already there (hence the failing test)

Costco
Coviran
Delhaize
Expand All @@ -54,13 +64,15 @@ Eurospin
Eroski
Esselunga
Foodtown
Fortnum & Mason
Franprix
Fred Meyer
Froiz
Giant Eagle
Hacendado
Haggen
Harris Teeter
Harrods
H-E-B
Heron Foods
Hipercor
Expand Down Expand Up @@ -257,6 +269,7 @@ SuperValu
Tang frères
Tesco
Toupargel
Magasins U||u Bio
Waitrose
Walmart
Wegmans
Expand Down
Loading