A few linguistic suggested changes + some details #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -92,12 +92,12 @@ There are two types of secrets: | |||
|
|
|||
| ## Settings | |||
|
|
|||
| Project settings are available only for project owners and collaborators with elevated permissions. From here a user can access some sensitive project settings or unrecoverable actions. | |||
| Project settings are available only to project owners and collaborators with elevated permissions (FIX ME: specify). _Settings_ should be handled carefully as users can modify sensitive project settings and perform unrecoverable actions. | |||
There was a problem hiding this comment.
It should be ascertained which elevated permissions suffice.
why-not-try-calmer
changed the title
suricactus
reviewed
Sep 7, 2023
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some are required for correctness, others are merely about style.
There's no particular reason why this file specifically. Just see a few things while working on something else in the docs pipeline.