Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added use volume keys to digitize #381

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Added use volume keys to digitize #381

merged 3 commits into from
Oct 11, 2023

Conversation

SeqLaz
Copy link
Member

@SeqLaz SeqLaz commented Oct 6, 2023

Added use volume keys to digitize in Digitizing section

@duke-nyuki
Copy link

Task linked: QF-3215 #4594 Implement digitizing throuhg volume keys on Android devices

suricactus
suricactus approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks good for me. Two small wording comments.

documentation/how-to/digitize.en.md Outdated Show resolved Hide resolved
documentation/how-to/digitize.en.md Outdated Show resolved Hide resolved
suricactus
suricactus approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks good for me. Two small wording comments.

SeqLaz and others added 2 commits October 11, 2023 06:50
@SeqLaz @suricactus
Update documentation/how-to/digitize.en.md
458070e 
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
@SeqLaz @suricactus
Update documentation/how-to/digitize.en.md
1684dea 
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
@SeqLaz
Copy link
Member Author

SeqLaz commented Oct 11, 2023

Thanks a lot, looks good for me. Two small wording comments.

Great improvments

@SeqLaz SeqLaz merged commit 55977f8 into master Oct 11, 2023
1 check passed
@SeqLaz SeqLaz deleted the QF-3215-digitizing-with-volume-keys branch October 11, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suricactus suricactus suricactus approved these changes

@m-kuhn m-kuhn Awaiting requested review from m-kuhn

@nirvn nirvn Awaiting requested review from nirvn

@lucienicolier lucienicolier Awaiting requested review from lucienicolier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeqLaz @duke-nyuki @suricactus